fix(datagrid): keep status bar controls clear of the window resize corner (#1569)#1577
Open
datlechin wants to merge 1 commit into
Open
fix(datagrid): keep status bar controls clear of the window resize corner (#1569)#1577datlechin wants to merge 1 commit into
datlechin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1569.
Problem
The last-page pagination button, and the other trailing status bar controls, sat flush in the bottom-right window corner where macOS reserves a 19x19pt live-resize grip. Hovering showed the diagonal resize cursor and the click resized the window instead of activating the button.
Fix
Status bar cleanup (same area)
Refactor
StatusBarSnapshottoModels/Query(Foundation only). It now carries the pagination-visibility predicates, and the row-info text formatting lives in a view-layer extension.MainStatusBarView's 21-parameter initializer into three callback/state bundles.Tests
StatusBarSnapshotTestscovering the row-info text branches and the pagination-visibility predicates.TableProUITestsdoes not have yet, so it is not included.Verify when running
The custom rows-per-page popover opens from a menu item. Confirm it presents; it anchors to a stable zero-size overlay on the page-size button.