fix: improve native tab bar appearance and dark mode handling#32
Merged
Conversation
Use performAsCurrentDrawingAppearance for correct colors during appearance transitions, track window key state for tab styling, and use accent-tinted selection instead of border-based highlight.
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
performAsCurrentDrawingAppearanceso colors resolve correctly during light/dark appearance transitionsdidBecomeKey/didResignKeynotifications and refresh appearance when the window gains or loses focuscontrolAccentColorat 15% opacity), and usequaternaryLabelColorfor hover stateTest plan