Publish app icons at apps/<app>/icon.png for SwiftDialog#5
Merged
Conversation
Adds 25 app icons under apps/<app_key>/icon.png to match the URL pattern that the SecondSon Baseline mobileconfig renders in Talieisin/intune: https://raw.githubusercontent.com/Talieisin/macos-scripts/main/apps/<app_key>/icon.png Previously these URLs 404'd on production ADE devices because the files weren't published. Baseline's SwiftDialog list view fell back to a default icon for every app. Icons cover both baseline-installed apps (Company Portal, Defender, Office, Tailscale, Jump Desktop, etc.) and Intune-deployed apps. Publishing the full set rather than just baseline ones so any future app reference resolves cleanly without a coordinated follow-up. Note: the existing icons/<app>.png directory in this repo (placeholder icons from initial commits) is now orphan — Terraform doesn't reference that path. Worth a follow-up cleanup PR.
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The icons/ directory dates from the initial commits and was never wired
into anything Terraform renders. The new apps/<app>/icon.png path
(added in this PR) supersedes it.
Notes on the removed files:
- gear.png, jumpdesktopconnect.png, tailscale.png — all 44815 bytes,
byte-identical placeholders (a "gear" image renamed three times)
- microsoftcompanyportal.png, microsoftdefender.png,
microsoftofficebusinesspro.png, microsoftteamsnew.png — proper
icons but at the wrong path. Their working versions are now under
apps/microsoftcompanyportal/icon.png etc.
No external references to icons/* anywhere — the orphan path can be
removed without breaking anything in production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The SecondSon Baseline mobileconfig in
Talieisin/intunerenders icon URLs as:Those URLs currently 404 on production ADE devices because the files were never published. Baseline's SwiftDialog list view falls back to a generic default icon for every line item.
What changed
Adds 25 PNGs at
apps/<app_key>/icon.pngcovering both baseline-installed apps and Intune-deployed apps:~2.4 MB total. Publishing the full set rather than just baseline ones so any future app reference (including non-baseline apps when Intune scripts use SwiftDialog) resolves cleanly without a coordinated follow-up.
Removes the orphan
icons/<app>.pngdirectory (7 PNGs from the initial commits). Nothing in Terraform or the repo references that path. Three of the files (gear.png,jumpdesktopconnect.png,tailscale.png) were byte-identical placeholders.Test plan
https://raw.githubusercontent.com/Talieisin/macos-scripts/main/apps/<app>/icon.pngfor any baseline-deployed app