You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Code Review: Support identifying with Apple Game Center
This PR adds Game Center authentication support to the Unity SDK. The implementation is clean and follows existing patterns well. Two issues worth addressing before merge.
🟡 Major — Missing .meta file for PlayersGameCenterIdentifier.cs
Every other file in Runtime/Requests/ has a corresponding .meta file (26 .meta files for 26 existing .cs files), but the new PlayersGameCenterIdentifier.cs.meta is absent from this PR.
Unity uses .meta files to assign stable GUIDs to assets. Without it, Unity will auto-generate a new GUID each time the project is opened, causing inconsistent asset tracking across developer machines and noisy future diffs.
Fix: Add PlayersGameCenterIdentifier.cs.meta with a stable, generated GUID alongside the new class file.
🔵 Minor — Renaming identity → identityClient in IdentifySteam is a source-breaking change
Renaming a parameter in a public method breaks any caller using a named argument:
// Breaks after the rename:awaitTalo.Players.IdentifySteam(ticket,identity:"myClient");
Positional callers are unaffected. The rename makes semantic sense, but it should be noted in a changelog so consumers can update their call sites.
No issues found
Code quality:IdentifyGameCenter follows the same structure as IdentifyGooglePlayGames and IdentifySteam — clean and consistent.
Encoding:Uri.EscapeDataString(JsonUtility.ToJson(payload)) correctly handles the base64-encoded signature/salt fields and the nested URL in publicKeyURL before passing to Identify.
Type safety:long for timestamp is appropriate — Apple's Game Center timestamp in milliseconds fits comfortably within Int64.
Security: No concerns; the Game Center token is opaque to the client and validated server-side.
Backwards compatibility: No existing Game Center callers to break.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.