Skip to content

Fix offline unified release gate - #78

Merged
tannerlinsley merged 1 commit into
mainfrom
codex/fix-release-consumer
Aug 9, 2026
Merged

Fix offline unified release gate#78
tannerlinsley merged 1 commit into
mainfrom
codex/fix-release-consumer

Conversation

@tannerlinsley

@tannerlinsley tannerlinsley commented Aug 9, 2026

Copy link
Copy Markdown
Member

Fixes the 0.9.0 publish failure in release run 31340548562. The unified core-only fixture now derives offline link overrides from every packed dependency and isolates pnpm store and metadata caches.\n\nValidated with 263 test files / 1,777 tests, the full pnpm validate graph, and all 12 0.9.0 release artifacts plus release:check.

Summary by CodeRabbit

  • Bug Fixes

    • Improved package release validation to prevent failures caused by inconsistent dependency resolution.
    • Strengthened offline installation checks for packaged releases, including linked dependencies and optional peer dependencies.
  • Tests

    • Expanded automated coverage for packed-package installation and validation.
    • Verified all 12 release artifacts install and validate successfully in isolated environments.
  • Documentation

    • Added release evidence documenting the 0.9.0 validation results and dependency-resolution issue.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 07e7c867-33b9-4afa-b670-40c598fe001a

📥 Commits

Reviewing files that changed from the base of the PR and between 2f547c1 and 0e0b74b.

📒 Files selected for processing (4)
  • API-FRICTION.md
  • scripts/ci-workflow.test.mjs
  • scripts/unified-package-artifact.mjs
  • scripts/unified-package-artifact.test.mjs

📝 Walkthrough

Walkthrough

Release validation now links packed dependencies to local packages and installs consumer fixtures offline with isolated pnpm state. Tests verify workspace overrides, peer handling, linked directories, and installation arguments. Release evidence records successful validation for all 12 artifacts.

Changes

Offline consumer validation

Layer / File(s) Summary
Dependency linking contract
scripts/unified-package-artifact.mjs, scripts/unified-package-artifact.test.mjs
The artifact script maps packed dependencies to local link: paths and generates workspace overrides. Tests verify the generated configuration and disabled optional peer installation.
Isolated consumer installation
scripts/unified-package-artifact.mjs
Consumer verification checks linked package directories and installs with an isolated offline pnpm store and XDG state directories.
Validation contracts and release evidence
scripts/ci-workflow.test.mjs, API-FRICTION.md
CI assertions verify the installation contract and reject --prefer-offline. Release evidence documents the dependency-resolution failure and successful validation of 12 artifacts.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PackedManifest
  participant ConsumerFixture
  participant Pnpm
  participant CI
  PackedManifest->>ConsumerFixture: derive local linked dependencies
  ConsumerFixture->>Pnpm: install offline with isolated state
  Pnpm-->>ConsumerFixture: validate installed fixture
  ConsumerFixture-->>CI: report contract results
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: fixing the offline unified release validation gate.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-release-consumer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 9, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 0e0b74b

Command Status Duration Result
nx run charts-workspace:ci-distributed ✅ Succeeded 2m 23s View ↗
nx run charts-workspace:package-check ✅ Succeeded <1s View ↗
nx run charts-workspace:benchmark-check ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-09 23:09:56 UTC

@tannerlinsley
tannerlinsley merged commit c17d677 into main Aug 9, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant