Skip to content

fix issue with using optional props in select and join clauses#377

Merged
samwillis merged 10 commits intomainfrom
samwillis/optional-types
Aug 5, 2025
Merged

fix issue with using optional props in select and join clauses#377
samwillis merged 10 commits intomainfrom
samwillis/optional-types

Conversation

@samwillis
Copy link
Copy Markdown
Collaborator

This also fixes using createCollection with a schema, and then using a live query on it - the types were not inferred in the query. This did not affect query or electric collections, but was apparent in the new tests.

fixes #299
fixes #300

@samwillis samwillis requested a review from KyleAMathews August 4, 2025 18:22
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Aug 4, 2025

🦋 Changeset detected

Latest commit: 0da41ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@tanstack/electric-db-collection Patch
@tanstack/query-db-collection Patch
@tanstack/db Patch
@tanstack/react-db Patch
@tanstack/solid-db Patch
@tanstack/svelte-db Patch
@tanstack/trailbase-db-collection Patch
@tanstack/vue-db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Aug 4, 2025

More templates

@tanstack/db

npm i https://pkg.pr.new/@tanstack/db@377

@tanstack/db-ivm

npm i https://pkg.pr.new/@tanstack/db-ivm@377

@tanstack/electric-db-collection

npm i https://pkg.pr.new/@tanstack/electric-db-collection@377

@tanstack/query-db-collection

npm i https://pkg.pr.new/@tanstack/query-db-collection@377

@tanstack/react-db

npm i https://pkg.pr.new/@tanstack/react-db@377

@tanstack/solid-db

npm i https://pkg.pr.new/@tanstack/solid-db@377

@tanstack/svelte-db

npm i https://pkg.pr.new/@tanstack/svelte-db@377

@tanstack/trailbase-db-collection

npm i https://pkg.pr.new/@tanstack/trailbase-db-collection@377

@tanstack/vue-db

npm i https://pkg.pr.new/@tanstack/vue-db@377

commit: 0da41ed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 4, 2025

Size Change: 0 B

Total Size: 58.5 kB

ℹ️ View Unchanged
Filename Size
./packages/db/dist/esm/change-events.js 1.13 kB
./packages/db/dist/esm/collection.js 9.85 kB
./packages/db/dist/esm/deferred.js 230 B
./packages/db/dist/esm/errors.js 2.98 kB
./packages/db/dist/esm/index.js 1.51 kB
./packages/db/dist/esm/indexes/auto-index.js 689 B
./packages/db/dist/esm/indexes/base-index.js 605 B
./packages/db/dist/esm/indexes/btree-index.js 1.47 kB
./packages/db/dist/esm/indexes/lazy-index.js 1.25 kB
./packages/db/dist/esm/local-only.js 827 B
./packages/db/dist/esm/local-storage.js 2.03 kB
./packages/db/dist/esm/optimistic-action.js 294 B
./packages/db/dist/esm/proxy.js 4.19 kB
./packages/db/dist/esm/query/builder/functions.js 575 B
./packages/db/dist/esm/query/builder/index.js 3.79 kB
./packages/db/dist/esm/query/builder/ref-proxy.js 890 B
./packages/db/dist/esm/query/compiler/evaluators.js 1.48 kB
./packages/db/dist/esm/query/compiler/expressions.js 631 B
./packages/db/dist/esm/query/compiler/group-by.js 2.03 kB
./packages/db/dist/esm/query/compiler/index.js 1.74 kB
./packages/db/dist/esm/query/compiler/joins.js 1.56 kB
./packages/db/dist/esm/query/compiler/order-by.js 677 B
./packages/db/dist/esm/query/compiler/select.js 655 B
./packages/db/dist/esm/query/ir.js 318 B
./packages/db/dist/esm/query/live-query-collection.js 2.45 kB
./packages/db/dist/esm/query/optimizer.js 2.44 kB
./packages/db/dist/esm/SortedMap.js 1.24 kB
./packages/db/dist/esm/transactions.js 2.29 kB
./packages/db/dist/esm/utils.js 419 B
./packages/db/dist/esm/utils/btree.js 5.93 kB
./packages/db/dist/esm/utils/comparison.js 718 B
./packages/db/dist/esm/utils/index-optimization.js 1.62 kB

compressed-size-action::db-package-size

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 4, 2025

Size Change: 0 B

Total Size: 1.05 kB

ℹ️ View Unchanged
Filename Size
./packages/react-db/dist/esm/index.js 152 B
./packages/react-db/dist/esm/useLiveQuery.js 902 B

compressed-size-action::react-db-package-size

@samwillis samwillis requested a review from kevin-dp August 5, 2025 12:25
Copy link
Copy Markdown
Collaborator

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important bug fixes & tons of great new tests! :shipit:

@KyleAMathews
Copy link
Copy Markdown
Collaborator

Also.... what if you could just write type logic in typescript or something. This is pretty simple logic but sooo complicated in Typescript.

@samwillis samwillis merged commit bb5d50e into main Aug 5, 2025
6 checks passed
@samwillis samwillis deleted the samwillis/optional-types branch August 5, 2025 16:40
@github-actions github-actions bot mentioned this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript error selecting an optional field. Typescript error joining on an optional field with eq.

2 participants