fix issue with using optional props in select and join clauses#377
Merged
fix issue with using optional props in select and join clauses#377
Conversation
🦋 Changeset detectedLatest commit: 0da41ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
More templates
@tanstack/db
@tanstack/db-ivm
@tanstack/electric-db-collection
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
Contributor
|
Size Change: 0 B Total Size: 58.5 kB ℹ️ View Unchanged
|
Contributor
|
Size Change: 0 B Total Size: 1.05 kB ℹ️ View Unchanged
|
KyleAMathews
approved these changes
Aug 5, 2025
Collaborator
KyleAMathews
left a comment
There was a problem hiding this comment.
Important bug fixes & tons of great new tests! ![]()
Collaborator
|
Also.... what if you could just write type logic in typescript or something. This is pretty simple logic but sooo complicated in Typescript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also fixes using
createCollectionwith a schema, and then using a live query on it - the types were not inferred in the query. This did not affect query or electric collections, but was apparent in the new tests.fixes #299
fixes #300