-
Notifications
You must be signed in to change notification settings - Fork 203
fix stuck loading state after an electric must-refetch #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@tanstack/electric-db-collection": patch | ||
| "@tanstack/db": patch | ||
| --- | ||
|
|
||
| Fixed a bug where a live query result could become inconsistent after an electric "must-refetch". | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@tanstack/electric-db-collection": patch | ||
| "@tanstack/db": patch | ||
| --- | ||
|
|
||
| Fixed a bug where a live query could get stuck in "loading" state when an electric "must-refetch" message arrived before the first "up-to-date". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -395,13 +395,14 @@ export class CollectionImpl< | |
| const callbacks = [...this.onFirstReadyCallbacks] | ||
| this.onFirstReadyCallbacks = [] | ||
| callbacks.forEach((callback) => callback()) | ||
|
|
||
| // to notify subscribers (like LiveQueryCollection) that the collection is ready | ||
| if (this.changeListeners.size > 0) { | ||
| this.emitEmptyReadyEvent() | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // Always notify dependents when markReady is called, after status is set | ||
| // This ensures live queries get notified when their dependencies become ready | ||
| if (this.changeListeners.size > 0) { | ||
| this.emitEmptyReadyEvent() | ||
| } | ||
|
Comment on lines
+401
to
+405
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the fix for the stuck loading state |
||
| } | ||
|
|
||
| public id = `` | ||
|
|
@@ -1270,6 +1271,13 @@ export class CollectionImpl< | |
| this.syncedData.clear() | ||
| this.syncedMetadata.clear() | ||
| this.syncedKeys.clear() | ||
|
|
||
| // 3) Clear currentVisibleState for truncated keys to ensure subsequent operations | ||
| // are compared against the post-truncate state (undefined) rather than pre-truncate state | ||
| // This ensures that re-inserted keys are emitted as INSERT events, not UPDATE events | ||
| for (const key of changedKeys) { | ||
| currentVisibleState.delete(key) | ||
| } | ||
|
Comment on lines
+1275
to
+1280
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the fix for the inconsistent state |
||
| } | ||
|
|
||
| for (const operation of transaction.operations) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.