Skip to content

test(preact-query-devtools): extract shared test setup into 'beforeEach' #11027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 2 commits into from
Jul 4, 2026
Merged

test(preact-query-devtools): extract shared test setup into 'beforeEach' #11027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4a17f2
test(preact-query-devtools): extract shared test setup into 'beforeEach'
sukvvon Jul 4, 2026
f8062fa
ci: apply automated fixes
autofix-ci[bot] Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
109 changes: 29 additions & 80 deletions packages/preact-query-devtools/src/__tests__/PreactQueryDevtools.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest'
import { render } from '@testing-library/preact'
import { QueryClient, QueryClientProvider } from '@tanstack/preact-query'
import { TanstackQueryDevtools } from '@tanstack/query-devtools'
import type { PreactQueryDevtools as PreactQueryDevtoolsComponent } from '../PreactQueryDevtools'

const mountMock = vi.fn()
const unmountMock = vi.fn()
Expand All @@ -26,22 +27,22 @@ vi.mock('@tanstack/query-devtools', () => ({
}))

describe('PreactQueryDevtools', () => {
beforeEach(() => {
let PreactQueryDevtools: typeof PreactQueryDevtoolsComponent
let queryClient: QueryClient

beforeEach(async () => {
vi.clearAllMocks()
;({ PreactQueryDevtools } = await import('../PreactQueryDevtools'))
queryClient = new QueryClient()
})

it('should throw an error if no query client has been set', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')

it('should throw an error if no query client has been set', () => {
expect(() => render(<PreactQueryDevtools />)).toThrow(
'No QueryClient set, use QueryClientProvider to set one',
)
})

it('should not throw an error if query client is provided via context', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should not throw an error if query client is provided via context', () => {
expect(() =>
render(
<QueryClientProvider client={queryClient}>
Expand All @@ -52,57 +53,40 @@ describe('PreactQueryDevtools', () => {
expect(mountMock).toHaveBeenCalled()
})

it('should not throw an error if query client is provided via props', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should not throw an error if query client is provided via props', () => {
expect(() =>
render(<PreactQueryDevtools client={queryClient} />),
).not.toThrow()
expect(mountMock).toHaveBeenCalled()
})

it('should forward "buttonPosition" to the devtools instance', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward "buttonPosition" to the devtools instance', () => {
render(
<PreactQueryDevtools client={queryClient} buttonPosition="top-left" />,
)

expect(setButtonPositionMock).toHaveBeenCalledWith('top-left')
})

it('should forward "position" to the devtools instance', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward "position" to the devtools instance', () => {
render(<PreactQueryDevtools client={queryClient} position="left" />)

expect(setPositionMock).toHaveBeenCalledWith('left')
})

it('should forward "initialIsOpen" to the devtools instance', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward "initialIsOpen" to the devtools instance', () => {
render(<PreactQueryDevtools client={queryClient} initialIsOpen={true} />)

expect(setInitialIsOpenMock).toHaveBeenCalledWith(true)
})

it('should default "initialIsOpen" to "false" when the prop is omitted', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should default "initialIsOpen" to "false" when the prop is omitted', () => {
render(<PreactQueryDevtools client={queryClient} />)

expect(setInitialIsOpenMock).toHaveBeenCalledWith(false)
})

it('should forward "errorTypes" to the devtools instance', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()
it('should forward "errorTypes" to the devtools instance', () => {
const errorTypes = [
{ name: 'Network', initializer: () => new Error('Network') },
]
Expand All @@ -112,47 +96,33 @@ describe('PreactQueryDevtools', () => {
expect(setErrorTypesMock).toHaveBeenCalledWith(errorTypes)
})

it('should default "errorTypes" to an empty array when the prop is omitted', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should default "errorTypes" to an empty array when the prop is omitted', () => {
render(<PreactQueryDevtools client={queryClient} />)

expect(setErrorTypesMock).toHaveBeenCalledWith([])
})

it('should forward "theme" to the devtools instance', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward "theme" to the devtools instance', () => {
render(<PreactQueryDevtools client={queryClient} theme="dark" />)

expect(setThemeMock).toHaveBeenCalledWith('dark')
})

it('should forward the resolved "QueryClient" via "setClient"', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward the resolved "QueryClient" via "setClient"', () => {
render(<PreactQueryDevtools client={queryClient} />)

expect(setClientMock).toHaveBeenCalledWith(queryClient)
})

it('should forward "styleNonce" to the devtools constructor', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward "styleNonce" to the devtools constructor', () => {
render(<PreactQueryDevtools client={queryClient} styleNonce="abc" />)

expect(TanstackQueryDevtools).toHaveBeenCalledWith(
expect.objectContaining({ styleNonce: 'abc' }),
)
})

it('should forward "shadowDOMTarget" to the devtools constructor', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()
it('should forward "shadowDOMTarget" to the devtools constructor', () => {
const shadowDOMTarget = document
.createElement('div')
.attachShadow({ mode: 'open' })
Expand All @@ -169,10 +139,7 @@ describe('PreactQueryDevtools', () => {
)
})

it('should forward "hideDisabledQueries" to the devtools constructor', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward "hideDisabledQueries" to the devtools constructor', () => {
render(
<PreactQueryDevtools client={queryClient} hideDisabledQueries={true} />,
)
Expand All @@ -182,10 +149,7 @@ describe('PreactQueryDevtools', () => {
)
})

it('should forward a "buttonPosition" change to the devtools instance after mount', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward a "buttonPosition" change to the devtools instance after mount', () => {
const { rerender } = render(
<PreactQueryDevtools
client={queryClient}
Expand All @@ -201,10 +165,7 @@ describe('PreactQueryDevtools', () => {
expect(setButtonPositionMock).toHaveBeenCalledWith('top-left')
})

it('should forward a "position" change to the devtools instance after mount', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward a "position" change to the devtools instance after mount', () => {
const { rerender } = render(
<PreactQueryDevtools client={queryClient} position="bottom" />,
)
Expand All @@ -215,10 +176,7 @@ describe('PreactQueryDevtools', () => {
expect(setPositionMock).toHaveBeenCalledWith('top')
})

it('should forward an "initialIsOpen" change to the devtools instance after mount', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward an "initialIsOpen" change to the devtools instance after mount', () => {
const { rerender } = render(
<PreactQueryDevtools client={queryClient} initialIsOpen={false} />,
)
Expand All @@ -229,10 +187,7 @@ describe('PreactQueryDevtools', () => {
expect(setInitialIsOpenMock).toHaveBeenCalledWith(true)
})

it('should forward an "errorTypes" change to the devtools instance after mount', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward an "errorTypes" change to the devtools instance after mount', () => {
const { rerender } = render(
<PreactQueryDevtools client={queryClient} errorTypes={[]} />,
)
Expand All @@ -248,10 +203,7 @@ describe('PreactQueryDevtools', () => {
expect(setErrorTypesMock).toHaveBeenCalledWith(errorTypes)
})

it('should forward a "theme" change to the devtools instance after mount', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should forward a "theme" change to the devtools instance after mount', () => {
const { rerender } = render(
<PreactQueryDevtools client={queryClient} theme="light" />,
)
Expand All @@ -262,10 +214,7 @@ describe('PreactQueryDevtools', () => {
expect(setThemeMock).toHaveBeenCalledWith('dark')
})

it('should call "unmount" on the devtools instance when the component unmounts', async () => {
const { PreactQueryDevtools } = await import('../PreactQueryDevtools')
const queryClient = new QueryClient()

it('should call "unmount" on the devtools instance when the component unmounts', () => {
const { unmount } = render(<PreactQueryDevtools client={queryClient} />)
unmount()

Expand All @@ -277,8 +226,8 @@ describe('PreactQueryDevtools', () => {
vi.resetModules()

try {
const { PreactQueryDevtools } = await import('..')
expect(PreactQueryDevtools({})).toBeNull()
const { PreactQueryDevtools: ProductionDevtools } = await import('..')
expect(ProductionDevtools({})).toBeNull()
} finally {
vi.unstubAllEnvs()
vi.resetModules()
Expand Down
Loading
Loading