Skip to content

test({react,preact}-query-devtools): assert the forwarded 'onClose' callback in the panel instead of 'expect.any(Function)' #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 1 commit into from
Jul 4, 2026
+8 −4
Merged

test({react,preact}-query-devtools): assert the forwarded 'onClose' callback in the panel instead of 'expect.any(Function)' #11029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/preact-query-devtools/src/__tests__/PreactQueryDevtoolsPanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,15 @@ describe('PreactQueryDevtoolsPanel', () => {

render(<PreactQueryDevtoolsPanel client={queryClient} onClose={onClose} />)

expect(setOnCloseMock).toHaveBeenCalledWith(expect.any(Function))
expect(setOnCloseMock).toHaveBeenCalledWith(onClose)
})

it('should default "onClose" to a no-op function when the prop is omitted', () => {
render(<PreactQueryDevtoolsPanel client={queryClient} />)

expect(setOnCloseMock).toHaveBeenCalledWith(expect.any(Function))
const forwarded = setOnCloseMock.mock.calls[0]?.[0]
expect(forwarded).toBeInstanceOf(Function)
expect(forwarded()).toBeUndefined()
})

it('should forward "errorTypes" to the devtools instance', () => {
Expand Down
6 changes: 4 additions & 2 deletions packages/react-query-devtools/src/__tests__/ReactQueryDevtoolsPanel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,15 @@ describe('ReactQueryDevtoolsPanel', () => {

render(<ReactQueryDevtoolsPanel client={queryClient} onClose={onClose} />)

expect(setOnCloseMock).toHaveBeenCalledWith(expect.any(Function))
expect(setOnCloseMock).toHaveBeenCalledWith(onClose)
})

it('should default "onClose" to a no-op function when the prop is omitted', () => {
render(<ReactQueryDevtoolsPanel client={queryClient} />)

expect(setOnCloseMock).toHaveBeenCalledWith(expect.any(Function))
const forwarded = setOnCloseMock.mock.calls[0]?.[0]
expect(forwarded).toBeInstanceOf(Function)
expect(forwarded()).toBeUndefined()
})

it('should forward "errorTypes" to the devtools instance', () => {
Expand Down
Loading