chore: upgrade to solid v2 rc, rename vite-plugin-solid, move branch to rc - #11173
Merged
birkskyum merged 1 commit intoAug 12, 2026
Merged
Conversation
…to rc - Bump solid-js, @solidjs/web, @solidjs/signals and babel-preset-solid 2.0.0-beta.33 -> ^2.0.0-rc.0 across the solid packages, the solid-vite integration and the solid examples, switching these from exact pins to carets so the rc line is picked up as it moves - Rename vite-plugin-solid -> @solidjs/vite-plugin ^3.0.0-next.27 (the version published under both names) in every manifest, vite config and the hydration test fixture; packages/query-devtools stays on vite-plugin-solid ^2.11.6 since it is still on solid 1.x - Drop the now-redundant `-i vite-plugin-solid` sherif ignore, since the dependency no longer resolves to more than one version - Raise the solid-query peer floor to >=2.0.0-rc.0 <3.0.0; the broader >=2.0.0-beta.0 floors on solid-query-devtools and solid-query-persist-client are left as they are - Switch the changesets prerelease tag from beta to rc, and set the solid package versions to the 6.0.0-rc sentinel so the next `changeset version` lands on 6.0.0-rc.0 rather than continuing the beta counter into 6.0.0-rc.9 - No source changes were needed; solid-query, solid-query-devtools and solid-query-persist-client pass unchanged (336 tests, no type errors), as do the solid-vite integration and solid example vite builds Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 19c7623
☁️ Nx Cloud last updated this comment at |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
birkskyum
approved these changes
Aug 12, 2026
brenelz
added a commit
to brenelz/query
that referenced
this pull request
Aug 12, 2026
Brings in the squash-merged TanStack#11173, which landed the solid v2 rc upgrade upstream. Two conflicts: - examples/solid/simple/package.json: kept our ^5.101.4 for @tanstack/eslint-plugin-query. The base branch still has ^5.101.0 because it has not taken main yet, and that bump is part of the main merge this branch delivers - pnpm-lock.yaml: regenerated from the merged manifests Verified after the merge: test:lib, test:types, test:build and test:eslint pass for all three solid packages, sherif and knip are clean, and the 6.0.0-rc sentinel matches what upstream now carries. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the v6 prerelease line onto the Solid 2.0 RC and switches this branch's prerelease tag from
betatorc.Solid RC, with carets
solid-js,@solidjs/web,@solidjs/signalsandbabel-preset-solidgo from the pinned2.0.0-beta.33to^2.0.0-rc.0across the three solid packages, thesolid-viteintegration and the solid examples. This also flips these deps from exact pins to carets so the rc line is tracked as it moves.packages/query-devtoolsis untouched — it is still on Solid 1.x.@tanstack/solid-query's peer floor moves to>=2.0.0-rc.0 <3.0.0. The deliberately broader>=2.0.0-beta.0 <3.0.0floors onsolid-query-devtoolsandsolid-query-persist-clientare left alone, matching how previous bumps handled them.vite-plugin-solid→@solidjs/vite-pluginRenamed to
@solidjs/vite-pluginat^3.0.0-next.27— the version published under both names, so a clean cut-over point. Covers every manifest, every vite config, and the hydration test fixture inpackages/solid-query/src/__tests__/fixtures/hydration/build-and-render.mjs.packages/query-devtoolsstays onvite-plugin-solid@^2.11.6; the scoped package has no 2.x line.The
-i vite-plugin-solidsherif ignore is dropped — with the rename the dependency no longer resolves to more than one version, so the ignore is redundant (verified sherif still passes without it).Prerelease tag →
rc, landing on6.0.0-rc.0.changeset/pre.jsonmoves from"tag": "beta"to"tag": "rc". No workflow change is needed:solid-query-v6-prestill matches the*-preglob inrelease.yml, which setsprerelease=trueand passes no--tag, sochangeset publishpicks the dist-tag up from pre.json.Changesets derives the pre number as
(prerelease[1] ?? -1) + 1, so switching the tag alone would have continued the beta counter and produced6.0.0-rc.9from6.0.0-beta.8. To land on6.0.0-rc.0instead, the three solid packages are set to the sentinel version6.0.0-rc— valid semver with no numeric prerelease part, so the pre number resolves to0whilesemver.inc("6.0.0-rc", "patch")still yields6.0.0.That sentinel only lives here until the next
ci: Version Packagescommit rewrites it; nothing publishes from it, since the release action runsversionbeforepublish.Verified by running the real
changeset versionagainst a throwaway copy of this tree:with the changelog entry landing as
## 6.0.0-rc.0directly above## 6.0.0-beta.8.Known peer warning
pnpm installreports an unmet peer for@solidjs/vite-plugin@3.0.0-next.27, which declaressolid-js/@solidjs/webas>=2.0.0-beta.32 <2.0.0-experimental.0. Prerelease identifiers sort alphabetically, so the real ordering isbeta.32 < experimental.0 < rc.0— the upper bound excludes the RC by accident.It is metadata only and warning only (no
strict-peer-dependenciesin this repo, and pnpm defaults it tofalse); the plugin works against rc.0. It should clear when Solid ships a plugin release with a corrected bound.@solidjs/vite-plugincurrently has exactly one published version, so there is nothing newer to move to.Verification
test:libon the three solid packages: 336 tests pass, no type errorstest:types,test:build,test:eslinton the three solid packages: passsherifandknip: passintegrations/solid-viteandexamples/solid/basic: passNo source changes were needed.
🤖 Generated with Claude Code