fix(codemods): Use .cjs extension for CommonJS files - #7333
Merged
Conversation
Rename CommonJS files in codemods to distinguish them from ES module files otherwise used in this project. Resolve an issue occuring since package.json in codemods is removed when publishing causing module type data to be lost. Fix issue TanStack#7154
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 32477e8:
|
lachlancollins
self-requested a review
April 24, 2024 21:48
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 32477e8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
lachlancollins
changed the title
ontanj
marked this pull request as draft
April 25, 2024 06:16
ontanj
marked this pull request as ready for review
April 25, 2024 06:59
github-actions
Bot
added
the
documentation
Contributor
Author
|
Another solution to #7154 would of course be to rewrite codemods as ES modules. Is there a reason it is using CommonJS? |
This was referenced May 23, 2024
This was referenced May 27, 2024
This was referenced May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename CommonJS files in codemods to distinguish them from ES module files otherwise used in this project.
Fix issue #7154 which occurs since package.json in codemods is removed when publishing, causing module type data to be lost.
The issue can also be fixed by adding package.json to the published package. But since the project mainly uses ES modules it makes sense to use .cjs for the others.