Skip to content

docs: Fixed invalid links - #7335

Closed
jungwoo3490 wants to merge 1 commit into
TanStack:mainfrom
jungwoo3490:fix-invalid-links
Closed

docs: Fixed invalid links#7335
jungwoo3490 wants to merge 1 commit into
TanStack:mainfrom
jungwoo3490:fix-invalid-links

Conversation

@jungwoo3490

@jungwoo3490 jungwoo3490 commented Apr 24, 2024

Copy link
Copy Markdown

Fixed #7334

Hi :)

I fixed all invalid links in https://github.com/TanStack/query/blob/2ffd9fbd848c8ce4b62f354b21ae25a2040eeae2/docs/framework/react/quick-start.md

I checked all links correctly work.

35d413b5-8f1b-48cb-b13a-c89af9c0589e.mp4

@vercel

vercel Bot commented Apr 24, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
query 猬滐笍 Ignored (Inspect) Visit Preview Apr 24, 2024 3:43pm

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 24, 2024
@jungwoo3490 jungwoo3490 changed the title docs: Fixed Invalid Links docs: Fixed invalid links Apr 24, 2024
@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4df6c4:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

@TkDodo

TkDodo commented Apr 24, 2024

Copy link
Copy Markdown
Collaborator

@fulopkovacs I thought we have fixed all broken links already?

@fulopkovacs

Copy link
Copy Markdown
Member

@TkDodo We did fix the links for the v5 docs, as you can see they are working in production (https://tanstack.com/query/latest/docs/framework/react/quick-start):

Kapture.2024-04-25.at.10.49.42.mp4

@jungwoo3490 Unfortunately, We can't trust VSCode errors in the case of relative links in the docs of the TanStack projects. This is related to the difference between how VSCode and TanStack router handle trailing slashes. See this comment for more info.

@jungwoo3490

Copy link
Copy Markdown
Author

Thanks for Checking!!! @fulopkovacs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Invalid links in quick-start.md

3 participants