Skip to content

fix(solid-query): ignore error if data undefined so can redirect #9841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
birkskyum merged 3 commits into from
Nov 3, 2025
Merged

fix(solid-query): ignore error if data undefined so can redirect #9841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8f2dbf
fix(solid-query): ignore error if data undefined so can redirect
brenelz Nov 3, 2025
1557f3e
ci: apply automated fixes
autofix-ci[bot] Nov 3, 2025
a6069f5
add changset
brenelz Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-lands-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/solid-query': patch
---

Skip errors if returned data is undefined
2 changes: 1 addition & 1 deletion packages/solid-query/src/useBaseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ export function useBaseQuery<
const query = observer().getCurrentQuery()
const unwrappedResult = hydratableObserverResult(query, result)

if (unwrappedResult.isError) {
if (result.data !== undefined && unwrappedResult.isError) {

@brenelz brenelz Nov 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this only skips it for the server subscriber. I am not sure if there is a better heuristic here instead of just data is undefined

reject(unwrappedResult.error)
unsubscribeIfQueued()
} else {
Expand Down
Loading