Proper handling of multiple setCookie calls

[ondrejvelisek]

Which project does this relate to?

Start

Describe the bug

Hi,

Ive encountered an interesting problem.

I have server function which is setting a cookie via setCookie("user_preferences", "preference_value"). And Im calling this function from within loader multiple times.

It sets the set-cookie header in a very wierd way.

If called 4 times it includes 4 set-cookie headers and fifth set-cookie header with 4 values repeated. See screenshot.

Your Example Website or App

https://github.com/ondrejvelisek/start-basic/
(Open root route and check response headers)

Steps to Reproduce the Bug or Issue

Use multiple setCookie with same name in the route loader.

Expected behavior

I would expect TanStart to deduplicate and set just the last called value.

Screenshots or Videos

Platform

• OS: macOS
• Browser: Chrome
• Version: -

Additional context

No response

[SeanCassiere]

Please attach a reproduction.

[SeanCassiere]

Closing as no reproduction was provided.

[ondrejvelisek]

@SeanCassiere reproduction here:
https://github.com/ondrejvelisek/start-basic/blob/main/app/routes/index.tsx

[SeanCassiere]

@SeanCassiere reproduction here:
https://github.com/ondrejvelisek/start-basic/blob/main/app/routes/index.tsx

These server side actions need to be happening within a createServerFn call.

[ondrejvelisek]

@SeanCassiere it does not matter in this case. The problem is still the same. See:
https://github.com/ondrejvelisek/start-basic/blob/main/app/routes/index.tsx

[ondrejvelisek]

@SeanCassiere there is still [information needed] label. Do you need something from me?

[SeanCassiere]

@ondrejvelisek thanks for the reminder about removing the label.

Update here: I haven't had time to properly investigate this yet. From a preliminary look, the setCookie function is being proxied out of vinxi/http, which in turn is wrapping it using getRequest that is exported from nitro and h3.

I'll try to see if there's anything that can be done on our side to fix this. If not, we'll likely need to log an issue with h3.

[brenelz]

Is this still an issue with the latest version without vinxi?

[schiller-manuel]

closing as no response was given.
if someone encounters a similar issue, please open a new github issue including a complete minimal example