Router searchParameter gets reset to default value (of zod schema) after navigations (and using retainSearchParams)

[hakoomen]

Which project does this relate to?

Router

Describe the bug

Using retained searchParams, if we change the retained param x form a to b on some route (lets say route-a) and we navigate to route-b, which doesn't change param x, param x will revert back to its default value.

This is a regression because it works on using older versions.

Same code older versions:
stackblitz
Same code latest versions:
stackblitz

Your Example Website or App

-see desc

Steps to Reproduce the Bug or Issue

1. click on Home route (see Auth defaults to true)
2. click on Settings route (see Auth remains true)
3. click on About route (see now Auth is false)
4. click on Home route:
   4.a older version: Auth remains as false (which is expected)
   4.b newer version: Auth changes back to true (which is unexpected)

Expected behavior

after chaning the retained searchParams, it should stay unchanged after navigations, and only change if explicitly said so.

• some other weird thing here is that even without using this middle params stay on URL, kinda making retainSearchParams useless, unless im not grasping the use of it correctly.

Screenshots or Videos

No response

Platform

• OS: [e.g. macOS, Windows, Linux]
• Browser: [e.g. Chrome, Safari, Firefox]
• Version: [e.g. 91.1]

Additional context

No response

[schiller-manuel]

which version exactly introduced the regression?

[FoHoOV]

hi @schiller-manuel, its specifically PR #2747,
works on @tanstack/react-router 1.81.4, doesnt on 1.81.5

[rminami]

I'm seeing the same issue too

[ChristianK43]

same here, can confirm that 1.81.5 introduced this bug

[FoHoOV]

@schiller-manuel can we fix this please, its really bugging me :(

[OwenVey]

Seeing the same issue. Confirmed on my end this broke going from 1.81.4 to 1.81.5

[hakoomen]

@schiller-manuel this bug destroys all navigations with default searchParams (overrides provided params with defaults). Can we make this a priority please? >_<

[leftmostgeek]

@schiller-manuel I will second @hakoomen. I got bit by this bug for a while. this would be great to get fixed, it does break navigation for me when going between pages.

@schiller-manuel this bug destroys all navigations with default searchParams (overrides provided params with defaults). Can we make this a priority please? >_<

[FoHoOV]

for all link components or navigate calls we have to pass the current sp values like:

await router.navigate({
  to: "/",
  search: (prev) => prev
});

which is another paintpoint

[TkDodo]

Can confirm the bug; The problem is that our internal validate middleware (that comes from validateSearchParams) runs first, so it sees an empty search and applies the schema, which adds default values. That happens before retainSearchParams runs).

It’s not as easy as just flipping the order though, as somethings have to run after validate. A bit tricky.

[jtannas]

The problem is that our internal validate middleware (that comes from validateSearchParams) runs first

Total newbie idea: Is it possible to expose the validateSearchParams middleware so that users have the option to control when validation happens? 🤔

Users could then work around this issue by placing the validation after the retainSearchParams.

e.g.

	validateSearch: undefined,
	search: {
		middlewares: [
			retainSearchParams(["foo"]),
			validateSearchParams(routeSchema),
		],
	},

It also gives users greater control for their more complex use cases.

[humarkx]

I dunno if it is related, and it might have to do with StrictMode, but when I open a url with search params, the first time I have access to them, the second time, they are undefined.

Is it also because of the validate?