@tanstack/start-storage-context seem wrong bundled in client side code that cause a node:async_hooks.AsyncLocalStorage bug

[phuongduyorg1]

Which project does this relate to?

Router, react-start

Describe the bug

New version update will cause a bug that node:async_hooks.AsyncLocalStorage is bundle in client side code.
i have reproduce it in a sandbox. you could see it's happend on /posts route
this screen shot is after i add a optimizeDeps: { exclude: ['@tanstack/start-storage-context', 'node:async_hooks'], }, ssr: { noExternal: ['@tanstack/start'], external: ['node:async_hooks'], }, in vite config

Your Example Website or App

https://codesandbox.io/p/sandbox/rough-snow-tqngv6

Steps to Reproduce the Bug or Issue

1. Create a middleware import { createMiddleware } from '@tanstack/react-start'; async function serverHandler({ next, context }: any) { const result = await next(); return result; } export const getUserContextMiddleware = createMiddleware({ type: 'function', }).server(serverHandler);
2. use it in a server function export const fetchPosts = createServerFn({ method: 'GET' }).middleware([getUserContextMiddleware]).handler( async () => { console.info('Fetching posts...') return axios .get<Array<PostType>>('https://jsonplaceholder.typicode.com/posts') .then((r) => r.data.slice(0, 10)) }, )

Expected behavior

Module "node:async_hooks" has been externalized for browser compatibility. Cannot access "node:async_hooks.AsyncLocalStorage" in client code will not be occurred

Screenshots or Videos

Platform

• Router / Start Version: 1.129.0
• OS: macOs
• Browser: Chrome
• Bundler: vite

Additional context

No response

[KiwiKilian]

This is only a problem during vite dev. This went through CI/CD and properly works on Prod on multiple of our apps.

[dylanhu7]

https://discord.com/channels/719702312431386674/1238170697650405547/1396658892519378944

Have noticed this is occurring in my minimal repro of all client-side interactivity breaking with 1.129.0, not sure if it's the cause though. https://codesandbox.io/p/github/dylanhu7/tss-1.129/main

[KiwiKilian]

You can use 1.128.8 until the problem is fixed. Possibly introduced by #4723.

[alxlacayo]

Getting this on a fresh install.
Module "node:async_hooks" has been externalized for browser compatibility. Cannot access "node:async_hooks.AsyncLocalStorage" in client code.

[ttessarolo]

Same problem here

[alexwork1611]

This is only a problem during vite dev. This went through CI/CD and properly works on Prod on multiple of our apps.

Can confirm this myself! It's the exact behavior I've experienced.

[alexwork1611]

You can use 1.128.8 until the problem is fixed. Possibly introduced by #4723.

I jus tried 1.128.8 and still had the problem. Reverting all my 1.129.0 TanStack packages to 1.128.3 fixed it for me.

[phuongduyorg1]

You can use 1.128.8 until the problem is fixed. Possibly introduced by #4723.

I jus tried 1.128.8 and still had the problem. Reverting all my 1.129.0 TanStack packages to 1.128.3 fixed it for me.

1.128.8 work fine for me. just need delete .lock file and remove node_modules

[spa5k]

it happens rather randomly for me, not in just this case (even in 1.128.8 and before). Can we get better info on what is causing this, like what component/function/route causes this.

[Nedi11]

I downgraded to 1.128.3 and it is still happening

[Luks17]

Can confirm this issue still happens even after downgrading to older versions.

I've tried clearing pnpm cache and even downgrading Vite, but it still hapens.

[max-programming]

For me, it doesn't work on the dev server but it works in prod

[briansunter]

I'm seeing it too on a fresh install
npx gitpick TanStack/router/tree/main/examples/react/start-basic start-basic
pnpm i
pnpm run dev