Skip to content

Replacing <StartClient /> with <RouterProvider /> fixes HMR #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
artimath wants to merge 1 commit into from
Closed

Replacing <StartClient /> with <RouterProvider /> fixes HMR #2292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions examples/react/start-trellaux/app/client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,21 @@
// import { hydrateRoot } from 'react-dom/client'
// import { StartClient } from '@tanstack/start'
// import { createRouter } from './router'

// const router = createRouter()

// hydrateRoot(document.getElementById('root')!, <StartClient router={router} />)

import React from 'react'
import { hydrateRoot } from 'react-dom/client'
import { StartClient } from '@tanstack/start'
import { RouterProvider } from '@tanstack/react-router'
import { createRouter } from './router'

const router = createRouter()

hydrateRoot(document.getElementById('root')!, <StartClient router={router} />)
hydrateRoot(
document.getElementById('root')!,
<React.StrictMode>
<RouterProvider router={router} />
</React.StrictMode>,
)
3 changes: 1 addition & 2 deletions examples/react/start-trellaux/app/components/Board.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ export function Board({ boardId }: { boardId: string }) {
}}
/>
</h1>

<div className="flex flex-grow min-h-0 h-full items-start px-8 pb-4 w-fit">
<h1 className="text-2xl text-black">hello123321123312</h1>
{columns.map((col, index) => {
return (
<ColumnComponent
Expand All @@ -101,7 +101,6 @@ export function Board({ boardId }: { boardId: string }) {
}}
/>
</div>

{/* trolling you to add some extra margin to the right of the container with a whole dang div */}
<div data-lol className="w-8 h-1 flex-shrink-0" />
</div>
Expand Down