Begin solid-router and router-core#3086
Conversation
|
View your CI Pipeline Execution ↗ for commit d6d2104.
☁️ Nx Cloud last updated this comment at |
|
The |
| LazyRouteOptions, | ||
| } from './fileRoute' | ||
|
|
||
| export * from '@tanstack/router-core' |
There was a problem hiding this comment.
I'm not sure this is great export * from '@tanstack/router-core'. I assume it's a result of moving the ./history.ts file over, and replacing the export * from './history', but the @tanstack/router-core contain a lot more.
| > | ||
| : TAcc | ||
|
|
||
| export type ParentPath<TOption> = 'always' extends TOption |
There was a problem hiding this comment.
These functions can't be extracted this easily - they depend on the AnyRouter now:
router/packages/react-router/src/routeInfo.ts
Lines 62 to 75 in 255f316
|
@Brendonovich FYI on the |
|
This is being continued on #3276, I'm happy to have got the ball rolling 😄 |
I've copied
react-routerintosolid-routerand replaced most of the React APIs with their Solid equivalent, and also extracted a lot of code that doesn't rely on Solid torouter-core, which we can later use inreact-router.solid-routerstill has a lot of issues (and seems to be running into solidjs/solid#2352), but a high number of tests are already passing.