fix: pin all workspace dependencies and devDependencies - #4771
Merged
Conversation
github-actions
Bot
added
package: router-plugin
package: router-generator
package: valibot-adapter
package: react-router-with-query
package: router-devtools
package: zod-adapter
package: router-vite-plugin
package: react-start-server
package: solid-start-server
package: react-router-devtools
package: solid-router-devtools
labels
Contributor
|
View your CI Pipeline Execution ↗ for commit d671dc8
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
Contributor
Author
|
Hmm not sure what's up with the failing check. It looks like all tests are passing (and so is but it seems an issue with corepack installing pnpm due to a mismatched key... and it seems to occur on other (green) PRs too. Can I ask for some guidance here? |
SeanCassiere
force-pushed
the
pin-packages
branch
from
July 26, 2025 05:12
f002c64 to
9b4f396
Compare
Member
|
Just checked on Discord, the installation failure looks to be a NX specific issue. For the time being, we'll leave this PR open till the NX Cloud Team have managed to resolve the issue on their end. |
schiller-manuel
force-pushed
the
pin-packages
branch
from
July 26, 2025 19:37
9b4f396 to
d671dc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I keep running into (mostly typing) issues when updating TSS packages to a version lower that latest, due to nested dependencies pulling a higher available version than the one I'm using.
I've updated all
"workspace:^"to"workspace:*"for all dependencies and devDependencies withinpackages/. I did not change anypeerDependenciesto allow flexibility on those.I also didn't change the package.jsons in
e2e/although I imagine those would be safe to pin exact as well.