docs: update RouteMatch type to include more properties based on Matches.d.ts#4894
Closed
mkarajohn wants to merge 1 commit into
Closed
docs: update RouteMatch type to include more properties based on Matches.d.ts#4894mkarajohn wants to merge 1 commit into
mkarajohn wants to merge 1 commit into
Conversation
Contributor
|
View your CI Pipeline Execution ↗ for commit d7d061c
☁️ Nx Cloud last updated this comment at |
More templates
@tanstack/arktype-adapter
@tanstack/directive-functions-plugin
@tanstack/eslint-plugin-router
@tanstack/history
@tanstack/react-router
@tanstack/react-router-devtools
@tanstack/react-router-with-query
@tanstack/react-start
@tanstack/react-start-client
@tanstack/react-start-plugin
@tanstack/react-start-server
@tanstack/router-cli
@tanstack/router-core
@tanstack/router-devtools
@tanstack/router-devtools-core
@tanstack/router-generator
@tanstack/router-plugin
@tanstack/router-utils
@tanstack/router-vite-plugin
@tanstack/server-functions-plugin
@tanstack/solid-router
@tanstack/solid-router-devtools
@tanstack/solid-start
@tanstack/solid-start-client
@tanstack/solid-start-plugin
@tanstack/solid-start-server
@tanstack/start-client-core
@tanstack/start-plugin-core
@tanstack/start-server-core
@tanstack/start-server-functions-client
@tanstack/start-server-functions-fetcher
@tanstack/start-server-functions-server
@tanstack/start-storage-context
@tanstack/valibot-adapter
@tanstack/virtual-file-routes
@tanstack/zod-adapter
commit: |
| headers?: Record<string, string> | ||
| globalNotFound?: boolean | ||
| ssr?: boolean | 'data-only' | ||
| displayPendingPromise?: Promise<void> |
Collaborator
There was a problem hiding this comment.
this is not a public API
| abortController: AbortController | ||
| cause: 'enter' | 'stay' | ||
| cause: 'preload' | 'enter' | 'stay' | ||
| fetchCount: number |
Collaborator
There was a problem hiding this comment.
@schiller-manuel Is fetchCount not meant to be public? Because it's also unused internally so maybe we can remove it?
| interface RouteMatch { | ||
| id: string | ||
| routeId: string | ||
| fullPath: string |
Member
|
Thanks for working on this. The I’ve opened #7789 to track the current docs correction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only added ones with a "clear" typing (no generic arguments, no fields starting with
_). I initially only wanted to document thefullPathbut then I saw there are more.