Skip to content

fix deps in example#7809

Merged
schiller-manuel merged 1 commit into
mainfrom
fix-niro-deps-example
Jul 13, 2026
Merged

fix deps in example#7809
schiller-manuel merged 1 commit into
mainfrom
fix-niro-deps-example

Conversation

@schiller-manuel

@schiller-manuel schiller-manuel commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Updated the Nitro package to a pinned beta release for improved version stability.

@nx-cloud

nx-cloud Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 57b0dd5

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 14m 34s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 21s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-13 19:39:50 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 257ba1c9-7e26-4052-aa5a-fa5a13ef60ae

📥 Commits

Reviewing files that changed from the base of the PR and between 41f7bf3 and 57b0dd5.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • examples/react/start-rscs/package.json

📝 Walkthrough

Walkthrough

The React RSC example updates its nitro dependency from the nightly npm alias to the ^3.0.260311-beta version range.

Changes

Nitro dependency

Layer / File(s) Summary
Update Nitro dependency
examples/react/start-rscs/package.json
Changes the nitro dependency from npm:nitro-nightly@latest to ^3.0.260311-beta.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: github-actions[bot], sheraff

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is relevant, but it is too vague to clearly describe the specific dependency change in the example. Use a more specific title, such as "Pin nitro version in start-rscs example".
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-niro-deps-example

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Jul 13, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7809

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7809

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7809

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7809

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7809

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7809

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7809

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7809

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7809

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7809

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7809

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7809

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7809

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7809

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7809

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7809

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7809

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7809

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7809

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7809

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7809

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7809

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7809

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7809

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7809

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7809

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7809

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7809

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7809

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7809

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7809

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7809

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7809

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7809

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7809

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7809

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7809

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7809

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7809

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7809

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7809

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7809

commit: 57b0dd5

@schiller-manuel schiller-manuel merged commit e65f0c8 into main Jul 13, 2026
10 checks passed
@schiller-manuel schiller-manuel deleted the fix-niro-deps-example branch July 13, 2026 19:44
brenelz added a commit that referenced this pull request Jul 14, 2026
…art-rscs

The pinned nitro-nightly@4.0.0-20251010 self-imports 'nitro/runtime/meta',
which under pnpm's isolated layout resolves to the hoisted nitro 3.x beta
and crashes vite config loading. Mirrors upstream fix e65f0c8 (#7809).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant