fix(router-generator): preserve dots in virtual routes by schiller-manuel · Pull Request #7845 · TanStack/router

schiller-manuel · 2026-07-17T22:43:22Z

Separate filesystem dot-delimited paths from explicit virtual paths and add regression coverage for layouts, routes, and physical prefixes.

fixes #7761

Summary by CodeRabbit

Bug Fixes
- Virtual routes now preserve dots in explicitly defined paths.
- Dots in pathless layout identifiers are treated as part of the route name rather than separators.
- Bracket-escaped dots in explicit paths are resolved correctly while retaining the original route definition.
Tests
- Added coverage for dotted virtual paths and dotted pathless layout filenames.

Separate filesystem dot-delimited paths from explicit virtual paths and add regression coverage for layouts, routes, and physical prefixes. fixes #7761

nx-cloud · 2026-07-17T22:43:51Z

View your CI Pipeline Execution ↗ for commit 4c425e0

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	16m 8s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2m 18s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-17 23:01:11 UTC

github-actions · 2026-07-17T22:44:45Z

🚀 Changeset Version Preview

1 package(s) bumped directly, 8 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
`@tanstack/router-generator`	1.167.20 → 1.167.21	Changeset
`@tanstack/react-start`	1.168.29 → 1.168.30	Dependent
`@tanstack/react-start-rsc`	0.1.28 → 0.1.29	Dependent
`@tanstack/router-cli`	1.167.20 → 1.167.21	Dependent
`@tanstack/router-plugin`	1.168.21 → 1.168.22	Dependent
`@tanstack/router-vite-plugin`	1.167.21 → 1.167.22	Dependent
`@tanstack/solid-start`	1.168.29 → 1.168.30	Dependent
`@tanstack/start-plugin-core`	1.171.21 → 1.171.22	Dependent
`@tanstack/vue-start`	1.168.28 → 1.168.29	Dependent

coderabbitai · 2026-07-17T22:45:49Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 36d7cec8-9d12-457c-b4c6-d3e6e14fa7d7

📥 Commits

Reviewing files that changed from the base of the PR and between 604996d and 4c425e0.

📒 Files selected for processing (14)

.changeset/tidy-virtual-route-dots.md
packages/router-generator/src/filesystem/virtual/getRouteNodes.ts
packages/router-generator/src/utils.ts
packages/router-generator/tests/generator.test.ts
packages/router-generator/tests/generator/virtual-explicit-dotted-paths/routeTree.snapshot.ts
packages/router-generator/tests/generator/virtual-explicit-dotted-paths/routes/direct.tsx
packages/router-generator/tests/generator/virtual-explicit-dotted-paths/routes/physical-routes/index.tsx
packages/router-generator/tests/generator/virtual-explicit-dotted-paths/routes/root.tsx
packages/router-generator/tests/generator/virtual-pathless-layout-dotted-filename/routeTree.snapshot.ts
packages/router-generator/tests/generator/virtual-pathless-layout-dotted-filename/routes/index.route.tsx
packages/router-generator/tests/generator/virtual-pathless-layout-dotted-filename/routes/pathless.layout.tsx
packages/router-generator/tests/generator/virtual-pathless-layout-dotted-filename/routes/root.route.tsx
packages/router-generator/tests/generator/virtual-pathless-layout-dotted-filename/routes/subpath.route.tsx
packages/router-generator/tests/utils.test.ts

📝 Walkthrough

Walkthrough

The router generator now uses separate parsing for explicit virtual route paths, preserving literal dots in route paths and pathless layout IDs. Utility tests and generated route-tree fixtures cover dotted explicit paths and dotted layout filenames.

Changes

Virtual route dot preservation

Layer / File(s)	Summary
Explicit route-path parsing `packages/router-generator/src/utils.ts`, `packages/router-generator/tests/utils.test.ts`	Extracts shared route-path parsing and adds `determineInitialRoutePathFromExplicitPath`, with tests for literal and bracket-escaped dots.
Virtual node path initialization `packages/router-generator/src/filesystem/virtual/getRouteNodes.ts`, `packages/router-generator/tests/generator.test.ts`, `.changeset/tidy-virtual-route-dots.md`	Uses explicit-path parsing for physical, route, and layout virtual nodes and adds generator configurations for dotted scenarios.
Generated route-tree fixtures `packages/router-generator/tests/generator/virtual-explicit-dotted-paths/`, `packages/router-generator/tests/generator/virtual-pathless-layout-dotted-filename/`	Adds route modules and generated snapshots for dotted explicit paths and pathless layout filenames.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

TanStack/router#6250: Updates related virtual route path parsing and escape handling.
TanStack/router#7453: Modifies related route-path initialization and escape handling.

Suggested labels: package: router-generator, documentation

Suggested reviewers: nlynzaad, seancassiere

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main fix: preserving dots in virtual routes.
Linked Issues check	✅ Passed	The changes add explicit-path handling and regression tests that keep dotted virtual layout routes intact as requested in `#7761`.
Out of Scope Changes check	✅ Passed	All changes support the dotted-virtual-route fix or add regression coverage and release notes; no unrelated code appears included.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix-7761

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-17T22:46:52Z

Bundle Size Benchmarks

Commit: 2f960ebf72c2
Measured at: 2026-07-17T22:46:09.907Z
Baseline source: history:604996d14c99
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
`react-router.minimal`	87.35 KiB	0 B (0.00%)	87.21 KiB	273.70 KiB	76.01 KiB	█████▁▁▁▁▁▁
`react-router.full`	91.06 KiB	0 B (0.00%)	90.92 KiB	285.59 KiB	79.19 KiB	█████▁▁▁▁▁▁
`solid-router.minimal`	35.53 KiB	0 B (0.00%)	35.40 KiB	105.90 KiB	31.94 KiB	█████▁▁▁▁▁▁
`solid-router.full`	40.58 KiB	0 B (0.00%)	40.46 KiB	121.11 KiB	36.51 KiB	█████▁▁▁▁▁▁
`vue-router.minimal`	53.00 KiB	0 B (0.00%)	52.87 KiB	149.94 KiB	47.63 KiB	█████▁▁▁▁▁▁
`vue-router.full`	58.94 KiB	0 B (0.00%)	58.81 KiB	168.70 KiB	52.76 KiB	█████▁▁▁▁▁▁
`react-start.minimal`	101.99 KiB	0 B (0.00%)	101.85 KiB	322.13 KiB	88.23 KiB	█████▁▁▁▁▁▁
`react-start.deferred-hydration`	102.72 KiB	0 B (0.00%)	101.87 KiB	323.50 KiB	88.88 KiB	█████▁▁▁▁▁▁
`react-start.full`	105.36 KiB	0 B (0.00%)	105.23 KiB	332.06 KiB	91.12 KiB	█████▁▁▁▁▁▁
`react-start.rsbuild.minimal`	99.68 KiB	0 B (0.00%)	99.51 KiB	316.57 KiB	85.74 KiB	█████▁▁▁▁▁▁
`react-start.rsbuild.minimal-iife`	100.08 KiB	0 B (0.00%)	99.91 KiB	317.51 KiB	86.11 KiB	█████▁▁▁▁▁▁
`react-start.rsbuild.full`	102.89 KiB	0 B (0.00%)	102.72 KiB	326.63 KiB	88.52 KiB	█████▁▁▁▁▁▁
`solid-start.minimal`	49.61 KiB	0 B (0.00%)	49.48 KiB	152.07 KiB	43.83 KiB	█████▁▁▁▁▁▁
`solid-start.deferred-hydration`	52.87 KiB	0 B (0.00%)	49.53 KiB	160.11 KiB	46.89 KiB	█████▁▁▁▁▁▁
`solid-start.full`	55.42 KiB	0 B (0.00%)	55.29 KiB	169.12 KiB	48.90 KiB	█████▁▁▁▁▁▁
`vue-start.minimal`	71.03 KiB	0 B (0.00%)	70.90 KiB	207.19 KiB	62.89 KiB	█████▁▁▁▁▁▁
`vue-start.full`	75.03 KiB	0 B (0.00%)	74.90 KiB	219.83 KiB	66.37 KiB	█████▁▁▁▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

pkg-pr-new · 2026-07-17T22:48:33Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7845

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7845

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7845

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7845

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7845

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7845

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7845

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7845

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7845

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7845

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7845

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7845

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7845

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7845

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7845

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7845

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7845

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7845

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7845

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7845

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7845

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7845

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7845

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7845

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7845

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7845

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7845

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7845

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7845

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7845

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7845

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7845

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7845

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7845

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7845

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7845

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7845

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7845

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7845

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7845

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7845

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7845

commit: 4c425e0

codspeed-hq · 2026-07-17T22:59:08Z

Merging this PR will regress 3 benchmarks

⚠️

Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 3 regressed benchmarks
✅ 171 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Memory	`mem server error-paths redirect (solid)`	441.2 KB	851.6 KB	-48.2%
❌	Memory	`mem server aborted-requests (vue)`	447.5 KB	466.2 KB	-4.02%
❌	Simulation	`client-route-tree-scale navigation loop (react)`	74.2 ms	77.1 ms	-3.79%
⚡	Memory	`mem server error-paths not-found (solid)`	817.3 KB	416.3 KB	+96.33%
⚡	Memory	`mem server error-paths redirect (vue)`	836.4 KB	527 KB	+58.72%
⚡	Memory	`mem server peak-large-page (solid)`	849.6 KB	759.8 KB	+11.81%
⚡	Memory	`mem client loader-data-retention (solid)`	157.9 KB	151.8 KB	+3.97%
⚡	Memory	`mem client preload-churn (vue)`	689.8 KB	666.5 KB	+3.49%
⚡	Simulation	`ssr streaming deferred (react)`	73.2 ms	71 ms	+3.11%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing fix-7761 (4c425e0) with main (604996d)}

fix(router-generator): preserve dots in virtual routes

4c425e0

Separate filesystem dot-delimited paths from explicit virtual paths and add regression coverage for layouts, routes, and physical prefixes. fixes #7761

github-actions Bot added the package: router-generator label Jul 17, 2026

schiller-manuel merged commit 78dd1a6 into main Jul 17, 2026
25 of 26 checks passed

schiller-manuel deleted the fix-7761 branch July 17, 2026 23:17

github-actions Bot mentioned this pull request Jul 17, 2026

ci: Version Packages #7846

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(router-generator): preserve dots in virtual routes#7845

fix(router-generator): preserve dots in virtual routes#7845
schiller-manuel merged 1 commit into
mainfrom
fix-7761

schiller-manuel commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Jul 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

pkg-pr-new Bot commented Jul 17, 2026

Uh oh!

codspeed-hq Bot commented Jul 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

schiller-manuel commented Jul 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 17, 2026

🚀 Changeset Version Preview

🟩 Patch bumps

Uh oh!

coderabbitai Bot commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Jul 17, 2026

Bundle Size Benchmarks

Uh oh!

pkg-pr-new Bot commented Jul 17, 2026

Uh oh!

codspeed-hq Bot commented Jul 17, 2026

Merging this PR will regress 3 benchmarks

Performance Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

schiller-manuel commented Jul 17, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Jul 17, 2026 •

edited

Loading

coderabbitai Bot commented Jul 17, 2026 •

edited

Loading