Fix an issue where pageIndex becomes invalid when data is changed (removed) and autoResetPageIndex is false. - #5031
Conversation
302bbe4 to
bb83e52
Compare
|
I like this! I have to get around it with an useEffect in my tanstack table code bases like this: Will look into merging this fix |
bb83e52 to
afdd446
Compare
|
Hi, Do you think this PR can be merged? |
|
Any news on when this will be merged? I am hoping to get this working to release app to production. This is a blocker if pagination does not reset when the last row is deleted in the last page and the table does not reset to the previous page. Please help. |
You can always just do this with your own code. Any fix here would just be a quality of life update. |
…moved) and autoResetPageIndex is false.
afdd446 to
d5066e9
Compare
|
@KevinVandy I have resolved the conflicts if we want to merge this PR |
If anyone else is facing this issue and this is not yet merged, here is the workaround for React: useEffect(() => {
const currentPageIndex = table.getState().pagination.pageIndex;
const lastPageIndex = table.getPageCount() - 1;
if (currentPageIndex > lastPageIndex) {
table.setPageIndex(lastPageIndex);
}
}, [data.length]); |
This fixes issue #4994
The pageIndex now gets set to correct value, if invalid, when autoResetPageIndex is false and data changes