fix: invalidate cached values after updating accessor functions - #5582
Closed
takoshi wants to merge 2 commits into
Closed
fix: invalidate cached values after updating accessor functions#5582takoshi wants to merge 2 commits into
takoshi wants to merge 2 commits into
Conversation
takoshi
marked this pull request as ready for review
May 25, 2024 08:10
|
Is this good to merge? |
2 tasks
|
Would love to see this merged! |
|
@tannerlinsley can we get some eyes on this? :) |
|
Hi @tannerlinsley, may you have a look at this one? |
|
@KevinVandy , (sorry to tag, saw you're active merging fixes on this repo) is it possible to get a review on this PR? I'm running into this problem and would like to avoid running a fork if this has a path to merge to main |
|
I feel like I'm also running into this one fwiw. |
alpha123
added a commit
to alpha123/uma-tools
that referenced
this pull request
Mar 8, 2026
see the removed comment in BasinnChart.tsx for exactly what bug was being fixed. fix ported from TanStack/table#5582. improves performance significantly when updating hints (also memoize some of the skill row components)
|
Any news on this ? Any workaround maybe ? We're getting into the same issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this PR
#5363
The above issue reported that
getValuesreturns stale cached values after changing accessor functions.This PR fixes it.
8cd8449: add unit tests
f66f4e6: accessor functions are also held as cache, and it determines whether the cached data are fresh or stale.