Skip to content

Remove principle card numbers#1052

Open
WaryaWayne wants to merge 1 commit into
TanStack:mainfrom
WaryaWayne:remove-principle-card-numbers
Open

Remove principle card numbers#1052
WaryaWayne wants to merge 1 commit into
TanStack:mainfrom
WaryaWayne:remove-principle-card-numbers

Conversation

@WaryaWayne

@WaryaWayne WaryaWayne commented Jul 21, 2026

Copy link
Copy Markdown

What changed

  • Removed the decorative 0104 numbers from the “Why TanStack?” principle cards.
  • Removed the now-unused array index parameter.

Why

The numbers overlapped other card content and did not provide useful information.

Validation

  • Verified locally in the browser
  • TypeScript passed
  • Lint passed
  • Unit tests passed: 24 passed, 1 skipped

Before:
before_warya_wayne_tanstack_remove_principal_numbers

After:
after_warya_wayne_tanstack_remove_principal_numbers

Summary by CodeRabbit

  • Style
    • Removed numbered badges from the “Why TanStack?” principles cards.
    • Principle cards now display only their content and supporting proof elements.

@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4aed4056-62bc-4d00-9680-357ce60d15f5

📥 Commits

Reviewing files that changed from the base of the PR and between 3b4add9 and 202c07e.

📒 Files selected for processing (1)
  • src/routes/index.tsx

📝 Walkthrough

Walkthrough

The “Why TanStack?” principles list no longer renders zero-padded ordinal badges. Principle content and PrincipleProof rendering remain unchanged.

Changes

Principle card display

Layer / File(s) Summary
Remove principle card ordinals
src/routes/index.tsx
The principles map no longer tracks an index, and each card’s numbered badge is removed while its content and proof remain rendered.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: tannerlinsley

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: removing the numbered principle card badges.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant