Skip to content

feat: add enabled option to Virtualizer - #724

Closed
shx-riff wants to merge 1 commit into
TanStack:mainfrom
shx-riff:feat/enabled
Closed

feat: add enabled option to Virtualizer#724
shx-riff wants to merge 1 commit into
TanStack:mainfrom
shx-riff:feat/enabled

Conversation

@shx-riff

@shx-riff shx-riff commented May 5, 2024

Copy link
Copy Markdown

@KevinVandy

Copy link
Copy Markdown
Member

I'm in favor of an enable/disable option. It would really help my MRT libraries.

Comment thread packages/virtual-core/src/index.ts
@piecyk

piecyk commented Jun 20, 2024

Copy link
Copy Markdown
Collaborator

@sxriff after reading the PR refactored it bit to handle reseting scroll offset, measurementsCache etc it's bit tricky when we also want to handle the initialRect, initialOffset etc, checkout the #741

@piecyk

piecyk commented Jun 21, 2024

Copy link
Copy Markdown
Collaborator

Thanks again for the PR @sxriff! We ended up merging another one #741 that covered this.

Closing this now. Appreciate your efforts and look forward to more contributions!

@piecyk piecyk closed this Jun 21, 2024
@shx-riff

Copy link
Copy Markdown
Author

Thanks again for the PR @sxriff! We ended up merging another one #741 that covered this.

Closing this now. Appreciate your efforts and look forward to more contributions!

@piecyk Thank you for reviewing and adding the feature, looking forward to using it in my project!

@shx-riff
shx-riff deleted the feat/enabled branch June 22, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants