Skip to content

Default value#312

Merged
CreepySkeleton merged 3 commits into
masterfrom
default_value
Dec 29, 2019
Merged

Default value#312
CreepySkeleton merged 3 commits into
masterfrom
default_value

Conversation

@CreepySkeleton

@CreepySkeleton CreepySkeleton commented Dec 21, 2019

Copy link
Copy Markdown
Collaborator

This is not meant to be released with the next patch, just some ongoing work.

Closes #123
Closes #142
Closes #150

TODO: docs, changelog

@CreepySkeleton

Copy link
Copy Markdown
Collaborator Author

Ready for review

Comment thread structopt-derive/src/attrs.rs Outdated
Comment thread structopt-derive/src/parse.rs
Comment thread tests/default_value.rs
@TeXitoi

TeXitoi commented Dec 28, 2019

Copy link
Copy Markdown
Owner

Overall great code!

@CreepySkeleton

Copy link
Copy Markdown
Collaborator Author

Ready

@TeXitoi TeXitoi left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Comment thread structopt-derive/src/attrs.rs Outdated
Comment thread structopt-derive/src/attrs.rs
Comment thread structopt-derive/src/attrs.rs Outdated
@TeXitoi

TeXitoi commented Dec 29, 2019

Copy link
Copy Markdown
Owner

A warning break the error message tests

@CreepySkeleton

Copy link
Copy Markdown
Collaborator Author

Not anymore

Comment thread src/lib.rs
@CreepySkeleton CreepySkeleton merged commit eaeb653 into master Dec 29, 2019
@CreepySkeleton CreepySkeleton deleted the default_value branch December 29, 2019 15:53
@CreepySkeleton

Copy link
Copy Markdown
Collaborator Author

Number of issues is less than 15! New achievement! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default_value from lazy Default Feature Request: useDefault, if implemented default_value and Option?

2 participants