fix: 피드 2차 QA 반영#814
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| class CreateFeedViewModel | ||
| @Inject | ||
| constructor( | ||
| class CreateFeedViewModel @Inject constructor( |
There was a problem hiding this comment.
🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline before annotation
| class CreateFeedViewModel | ||
| @Inject | ||
| constructor( | ||
| class CreateFeedViewModel @Inject constructor( |
There was a problem hiding this comment.
🚫 [ktlint] standard:annotation reported by reviewdog 🐶
Expected newline after last annotation
| private val feedRepository: FeedRepository, | ||
| private val feedRepository: UpdatedFeedRepository, | ||
| ) : ViewModel() { | ||
|
|
There was a problem hiding this comment.
🚫 [ktlint] standard:no-empty-first-line-in-class-body reported by reviewdog 🐶
Class body should not start with blank line
| feedRepository.saveFeed( | ||
| relevantCategories = categories | ||
| .filter { it.isSelected } | ||
| relevantCategories = categories.filter { it.isSelected } |
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
| imageUrls = feed.imageUrls, | ||
| ) | ||
| } ?: throw IllegalArgumentException() | ||
| updatedFeedViewModel.uiState.value.myFeedData.feeds.find { it.id == feedId } |
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
| lastFeedId = lastFeedId, | ||
| genres = state.currentFilter.selectedGenres.map { it.tag }, | ||
| isVisible = state.currentFilter.isVisible, | ||
| sortCriteria = state.myFeedData.sort.name.uppercase(), |
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
| }.onFailure { | ||
| _uiState.update { it.copy(loading = false, isRefreshing = false, error = true) } | ||
|
|
||
| FeedTab.SOSO_FEED -> getFeedsUseCase( |
There was a problem hiding this comment.
🚫 [ktlint] standard:when-entry-bracing reported by reviewdog 🐶
Body of when entry should be surrounded by braces if any when entry body is surrounded by braces or has a multiline body
| }, | ||
| isLoadable = result.isLoadable, | ||
| ) | ||
| currentState.updateCurrentSource(updatedSource) |
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
| } | ||
| fun updateTab(tab: FeedTab) { | ||
| _uiState.update { it.copy(selectedTab = tab) } | ||
| if (uiState.value.currentData.feeds.isEmpty()) fetchNextPage(feedId = 0L) |
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
| fun updateSosoCategory(category: SosoFeedType) { | ||
| if (uiState.value.sosoCategory == category) return | ||
| _uiState.update { it.copy(sosoCategory = category) } | ||
| if (uiState.value.currentData.feeds.isEmpty()) fetchNextPage(feedId = 0L) |
There was a problem hiding this comment.
🚫 [ktlint] standard:chain-method-continuation reported by reviewdog 🐶
Expected newline before '.'
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴