fix: 피드 필터 카테고리 칩사이 간격 수정#869
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Walkthrough안드로이드 디버그 APK의 빌드 메타데이터 JSON을 추가하고, 피드 필터 모달의 칩 간격과 스타일링을 조정하며, 소설 카테고리 열거형 항목의 순서를 변경하고 한글 표기를 수정한 후, 라이브러리 필터의 아이콘 크기를 변경했습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
feature/feed/src/main/java/com/into/websoso/feature/feed/component/MyFeedFilterModal.kt (1)
249-257: 선택형 칩은clickable보다selectable사용이 더 안전합니다.현재 구현은 시각 상태는 반영되지만, 접근성 서비스(TalkBack)에 선택 상태 전달이 약할 수 있습니다. 선택형 컴포넌트로
selectable(selected = …, role = …)를 권장합니다.수정 제안 diff
+import androidx.compose.foundation.selection.selectable +import androidx.compose.ui.semantics.Role ... Box( modifier = modifier .clip(RoundedCornerShape(size = 20.dp)) .border( width = 1.dp, color = if (isSelected) Primary100 else Gray50, shape = RoundedCornerShape(size = 20.dp), - ).background(color = if (isSelected) Primary50 else Gray50) - .clickable(onClick = onChipClick), + ) + .background(color = if (isSelected) Primary50 else Gray50) + .selectable( + selected = isSelected, + onClick = onChipClick, + role = Role.Checkbox, + ), contentAlignment = Alignment.Center, ) {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@feature/feed/src/main/java/com/into/websoso/feature/feed/component/MyFeedFilterModal.kt` around lines 249 - 257, The Box currently uses .clickable(onClick = onChipClick) which does not expose selection semantics to accessibility services; replace .clickable with .selectable(selected = isSelected, onClick = onChipClick, role = Role.Button) (import androidx.compose.foundation.selection.selectable and androidx.compose.ui.semantics.Role) so TalkBack receives the selection state—apply this change where the Box modifier is built (reference: Box, modifier, isSelected, onChipClick) and keep the existing clip/border/background chain intact.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@app/debug/output-metadata.json`:
- Around line 1-21: Remove app/debug/output-metadata.json from the PR (revert
the commit or delete the file in this branch) because it is an autogenerated
debug APK metadata file unrelated to the UI change; then add an appropriate
ignore rule (e.g., ignore output-metadata.json or the debug/ directory) to the
repo’s .gitignore to prevent re-adding it in future commits and ensure only
intentional build artifacts are tracked.
---
Nitpick comments:
In
`@feature/feed/src/main/java/com/into/websoso/feature/feed/component/MyFeedFilterModal.kt`:
- Around line 249-257: The Box currently uses .clickable(onClick = onChipClick)
which does not expose selection semantics to accessibility services; replace
.clickable with .selectable(selected = isSelected, onClick = onChipClick, role =
Role.Button) (import androidx.compose.foundation.selection.selectable and
androidx.compose.ui.semantics.Role) so TalkBack receives the selection
state—apply this change where the Box modifier is built (reference: Box,
modifier, isSelected, onChipClick) and keep the existing clip/border/background
chain intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7bfd6ec3-b16c-4458-92a7-1bcbc043ce92
📒 Files selected for processing (4)
app/debug/output-metadata.jsonfeature/feed/src/main/java/com/into/websoso/feature/feed/component/MyFeedFilterModal.ktfeature/feed/src/main/java/com/into/websoso/feature/feed/model/NovelCategory.ktfeature/library/src/main/java/com/into/websoso/feature/library/filter/component/LibraryFilterBottomSheetAttractivePoints.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
Summary by CodeRabbit
릴리스 노트
버그 수정
스타일 개선