-
Notifications
You must be signed in to change notification settings - Fork 1
fix: 홈화면 1차 QA #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fix: 홈화면 1차 QA #902
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
650d5bd
fix: 인기 피드 슬롯 UI 수정
devfeijoa ca49791
fix: 인기 피드 UI 레이아웃 및 제목 생략 로직 수정
devfeijoa 4f14ab3
fix: 홈 화면 인기 피드 최대 노출 개수 제한 및 로직 수정
devfeijoa 8f641d8
fix: 인기 작품 아이템 UI 배경 리소스 수정
devfeijoa 7049228
fix: 인기 작품 제목 생략(Ellipsis) 로직 및 문자열 리소스 수정
devfeijoa b26ae62
fix: 홈 화면 인기 소설 작가명 말줄임표 처리 추가
devfeijoa 66a5143
fix: 인기 작품 아이템 커버 이미지 UI 수정 및 그림자 효과 추가
devfeijoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 19 additions & 7 deletions
26
app/src/main/res/drawable/bg_popular_novel_bottom_radius_14dp.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,19 @@ | ||
| <shape xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:shape="rectangle"> | ||
| <solid android:color="#FCF8F6" /> | ||
| <corners | ||
| android:bottomLeftRadius="14dp" | ||
| android:bottomRightRadius="14dp" /> | ||
| </shape> | ||
| <layer-list xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <item> | ||
| <shape android:shape="rectangle"> | ||
| <solid android:color="#F6F6F8" /> | ||
| <corners | ||
| android:bottomLeftRadius="14dp" | ||
| android:bottomRightRadius="14dp" /> | ||
| </shape> | ||
| </item> | ||
|
|
||
| <item> | ||
| <shape android:shape="rectangle"> | ||
| <solid android:color="#B2FFFFFF" /> | ||
| <corners | ||
| android:bottomLeftRadius="14dp" | ||
| android:bottomRightRadius="14dp" /> | ||
| </shape> | ||
| </item> | ||
| </layer-list> |
5 changes: 0 additions & 5 deletions
5
app/src/main/res/drawable/bg_popular_novel_translucent_radius_14dp.xml
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.