Fix #174: remove vop from M commands - #180
Merged
thierry-martinez merged 15 commits intoJul 25, 2024
Merged
Conversation
This commit removes the `vop` attribute from `M` commands, and adds a `clifford` method to `M` commands: this method takes a Clifford gate and returns a new `M` command where the plane, the angle, and the s- and t-domains have been updated, so as to be equivalent to apply the given Clifford gate prior to the measure. Standardization, signal shifting and tensor network simulator have been fixed for planes other than XY.
shinich1
reviewed
Jul 25, 2024
shinich1
reviewed
Jul 25, 2024
Contributor
|
@thierry-martinez thanks! this looks really nice approach. examples rendered well. we might want to add |
EarlMilktea
requested changes
Jul 25, 2024
Contributor
|
@thierry-martinez I think we can merge #182 before this, so that ruff will be added to checks (resolving that may auto-resolve some of above comments by @EarlMilktea). |
Shinichi's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
Contributor
|
@thierry-martinez Could you resolve the remaining three threads? Once ready, I will approve merge. |
EarlMilktea's review: TeamGraphix#180 (comment)
EarlMilktea's review: TeamGraphix#180 (comment)
Collaborator
Author
|
Oops, sorry for having missed them (they were folded in "3 hidden more conversations")! All of them should be fixed now. Thanks! |
EarlMilktea
approved these changes
Jul 25, 2024
Collaborator
Author
|
Merged. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
vopattribute fromMcommands, and adds acliffordmethod toMcommands: this method takes a Clifford gate and returns a newMcommand where the plane, the angle, and the s- and t-domains have been updated, so as to be equivalent to apply the given Clifford gate prior to the measure.Standardization, signal shifting and tensor network simulator have been fixed for planes other than XY.