Skip to content

refactor: 토너먼트 시작 409 시 match 페이지로 복구 이동 #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iOdiO89 merged 2 commits into from
Jul 15, 2026
+18 −0
Merged

refactor: 토너먼트 시작 409 시 match 페이지로 복구 이동 #331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6b569e
refactor: 토너먼트 시작 409 시 match 페이지로 복구 이동
kanghaeun Jul 12, 2026
4a33e36
refactor: 4xx 에러 문구를 getApiErrorMessage 유틸로 통일
kanghaeun Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions apps/web/src/app/tournament/[id]/create/_hooks/usePostTournamentStart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,13 @@
import { useMutation } from '@tanstack/react-query';
import { isAxiosError } from 'axios';
import { useRouter } from 'next/navigation';
import { toast } from 'sonner';

import { ANALYTICS_EVENT } from '@/consts/analytics';
import { ROUTES } from '@/consts/route';
import type { ApiErrorResponseT } from '@/types/api';
import { logAnalyticsEvent } from '@/utils/analytics';
import { getApiErrorMessage } from '@/utils/getApiErrorMessage';

import { postTournamentStart } from '../_apis/postTournamentStart';

Expand All @@ -23,6 +27,20 @@ export const usePostTournamentStart = (tournamentId: number) => {
});
router.push(ROUTES.TOURNAMENT_LOADING(nextTournamentId));
},
onError: error => {
if (!isAxiosError<ApiErrorResponseT>(error) || !error.response) return;

const { status } = error.response;

if (status === 409) {
router.push(ROUTES.TOURNAMENT_MATCH(tournamentId));
return;
}

if (status < 500) {
toast.error(getApiErrorMessage(error));
Comment on lines +40 to +41

@coderabbitai coderabbitai Bot Jul 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

토스트 처리를 4xx 응답으로 제한해 주세요.

status < 500은 3xx 또는 1xx 응답까지 포함하므로, PR 요구사항인 “409 이외의 4xx 오류만 토스트 표시”보다 범위가 넓습니다. status >= 400 && status < 500으로 제한하는 편이 안전합니다.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/web/src/app/tournament/`[id]/create/_hooks/usePostTournamentStart.ts
around lines 40 - 41, Update the status condition in the error handling around
getApiErrorMessage to show a toast only for 4xx responses, using a range check
from 400 inclusive to 500 exclusive; preserve the existing behavior that
excludes status 409 if handled elsewhere.

}
},
});

return { postTournamentStartMutation, isPostTournamentStartPending };
Expand Down
Loading