fix: 내 토너먼트 페이지 게스트도 접근 가능하도록 변경 - #368
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Discord 스레드 연동용 메타데이터입니다. discord-pr-bot 워크플로가 자동 생성하며, 수정·삭제하면 PR 과 Discord 알림 연동이 끊깁니다. |
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough위시 보관 레이아웃의 컴포넌트 이름을 Changes위시 보관 레이아웃
Estimated code review effort: 2 (Simple) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/app/archive/wish/layout.tsx`:
- Around line 28-29: In the wish layout’s member-check flow, keep only the
identity evaluation inside the try block, then move the WishLoginRequired early
return after the try/catch so the login prompt renders outside the
error-boundary-protected section.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f2b79f8d-ac91-403f-84e4-83166018998c
📒 Files selected for processing (1)
apps/web/src/app/archive/wish/layout.tsx
* fix: 내 토너먼트 페이지 게스트도 접근 가능하도록 변경 * fix: 위시 아카이브 로그인 유도 렌더를 try/catch 밖으로 분리
* fix: proxy에서 세션쿠키로 적용되던 오류 수정 * feat: JWT 토큰 유틸 @piki/core 추가 (iat 비교·유효성·만료 계산) * fix: 앱 토큰 동기화에 iat 비교 도입해 로그인 풀림 방지 * refactor: 웹 JWT 유틸 @piki/core로 이전 * fix: 토큰 갱신 응답 body를 camelCase로 파싱하도록 수정 (rotation 토큰 유실 해결) * fix: 웹뷰 워밍업 후 쿠키 동기화 + 양방향 동기화 훅 통합 (iOS 쿠키 유실 방지) * refactor: 토큰 갱신 응답 타입 AuthTokensT를 @piki/core로 추출 * chore: 미사용 jwt 타입 export 삭제 * fix: 내 토너먼트 페이지 게스트도 접근 가능하도록 변경 (#368) * fix: 내 토너먼트 페이지 게스트도 접근 가능하도록 변경 * fix: 위시 아카이브 로그인 유도 렌더를 try/catch 밖으로 분리
작업 요약
archive/tournament) 페이지에 게스트가 접근할 수 있도록 권한 검사 위치를 옮겼습니다.작업 세부 내용
archive/layout.tsx에서 MEMBER 권한 검사를 하고 있어, 게스트가archive하위(토너먼트 포함) 전체에 접근하지 못했습니다.archive/wish/layout.tsx로 이동했습니다. (git mv— rename으로 추적)archive/wish/*) 서브트리에만 적용되고, 토너먼트는 게이트 없이 게스트·멤버 모두 접근 가능합니다.redirectPath?.startsWith(ROUTES.WISHLIST)분기가 항상 참이 되므로, 비멤버는 곧바로WishLoginRequired를 렌더하도록 단순화했습니다. (도달 불가능해진redirect분기와 미사용ROUTESimport 제거)연관 이슈
closes #335
Summary by CodeRabbit