style: 에러/404/500 페이지 디자인 적용 및 토스트 하단 위치 수정 - #428
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Discord 스레드 연동용 메타데이터입니다. discord-pr-bot 워크플로가 자동 생성하며, 수정·삭제하면 PR 과 Discord 알림 연동이 끊깁니다. |
|
Warning Review limit reached
Next review available in: 43 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough오류 및 404 페이지에 새 디자인과 공통 버튼 스타일을 적용했습니다. 토스트 위치와 입력 placeholder 색상을 변경했습니다. 위시와 토너먼트 관련 사용자-facing 문구, 입력 placeholder, E2E 검증 문자열을 정비했습니다. ChangesUI 스타일 및 문구 정비
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/web/src/app/error.tsx (1)
22-23: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win오류 화면의 주 콘텐츠 컨테이너를
<main>으로 변경하세요.현재 화면에는 주 콘텐츠 랜드마크가 없습니다. 각 화면의 최상위 콘텐츠 컨테이너를
<main>으로 변경하세요.
apps/web/src/app/error.tsx#L22-L23: 최상위 콘텐츠div를<main>으로 변경하세요.apps/web/src/app/global-error.tsx#L25-L26:body내부의 최상위 콘텐츠div를<main>으로 변경하세요.apps/web/src/app/not-found.tsx#L9-L10: 최상위 콘텐츠div를<main>으로 변경하세요.As per coding guidelines, “컨테이너에는 semantic tag인
<main>을 사용하고 제목에는<h1>또는<h2>를 사용한다.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/web/src/app/error.tsx` around lines 22 - 23, Replace the top-level content container div with main in apps/web/src/app/error.tsx lines 22-23, apps/web/src/app/global-error.tsx lines 25-26, and apps/web/src/app/not-found.tsx lines 9-10, preserving the existing classes and contents.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/app/error.tsx`:
- Line 23: Update the calc() padding-top expressions to include spaces around
the subtraction operator so they are valid CSS: change the affected classes in
apps/web/src/app/error.tsx at lines 23-23, apps/web/src/app/global-error.tsx at
lines 26-26, and apps/web/src/app/not-found.tsx at lines 10-10.
---
Nitpick comments:
In `@apps/web/src/app/error.tsx`:
- Around line 22-23: Replace the top-level content container div with main in
apps/web/src/app/error.tsx lines 22-23, apps/web/src/app/global-error.tsx lines
25-26, and apps/web/src/app/not-found.tsx lines 9-10, preserving the existing
classes and contents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 514d4e45-65a4-412e-9827-107f8cf7df69
⛔ Files ignored due to path filters (1)
apps/web/src/assets/images/basket-not-found.svgis excluded by!**/*.svg
📒 Files selected for processing (16)
apps/web/e2e/specs/home/home.spec.tsapps/web/src/app/archive/wish/[id]/_components/EditContent.tsxapps/web/src/app/archive/wish/_components/WishGridContent.tsxapps/web/src/app/error.tsxapps/web/src/app/global-error.tsxapps/web/src/app/home/_components/CreateTournamentDialog.tsxapps/web/src/app/home/_components/InviteTournamentDialog.tsxapps/web/src/app/home/_components/tournament-list/index.tsxapps/web/src/app/mypage/withdraw/page.tsxapps/web/src/app/not-found.tsxapps/web/src/app/tournament/[id]/item/[itemId]/_components/EditContent.tsxapps/web/src/app/tournament/join/[id]/_components/JoinPreviewClient.tsxapps/web/src/components/common/create-tournament-dialog/index.tsxapps/web/src/components/get-item-dialog/index.tsxapps/web/src/components/input/index.tsxapps/web/src/components/toast/index.tsx
* style: 서비스 전반 워딩 통일 (위시템→위시, 초대→공유) * test: 홈 토너먼트 목록 헤딩 워딩 변경에 맞게 E2E 테스트 수정 * style: 토스트 하단 offset 52px로 수정 * style: 404 페이지 디자인 적용 * style: 500 에러 페이지 디자인 적용 * fix: calc() 연산자 공백 추가 --------- Co-authored-by: soyeong <mb535622@sookmyung.ac.kr>
1 participant
작업 요약
작업 세부 내용
스크린샷
연관 이슈
closes #427
Summary by CodeRabbit
새로운 기능
개선 사항
테스트