removing data_files#283
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughRemoved the repository's sample data/configuration artifacts under Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/test_cli.py`:
- Around line 160-161: Introduce a single shared constant (e.g.,
TUTORIAL_UTOPIA_SQL or UTOPIA_SQL_FIXTURE) that holds the Path(...) to the
utopia.sql fixture and replace the repeated inline assignments to input_file_src
in tests with that constant; update references in the test functions that
currently set input_file_src so they import or reference this new constant
(ensure the constant is defined at module scope near the top of
tests/test_cli.py and used in places that previously duplicated the Path).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6a83dc38-af63-4f91-bd5b-13d07def6d98
📒 Files selected for processing (1)
tests/test_cli.py
ade24d5 to
7637310
Compare
No longer maintained or necessary since we have moved to a directory structure compatible with pip installation.
Relevant schemas are now in
temoa/db_schemaand sql files are built as needed during tests as mentioned in #239Summary by CodeRabbit