Skip to content

removing data_files#283

Merged
ParticularlyPythonicBS merged 2 commits intounstablefrom
remove_data_files
Mar 24, 2026
Merged

removing data_files#283
ParticularlyPythonicBS merged 2 commits intounstablefrom
remove_data_files

Conversation

@ParticularlyPythonicBS
Copy link
Copy Markdown
Member

@ParticularlyPythonicBS ParticularlyPythonicBS commented Mar 24, 2026

No longer maintained or necessary since we have moved to a directory structure compatible with pip installation.
Relevant schemas are now in temoa/db_schema and sql files are built as needed during tests as mentioned in #239

Summary by CodeRabbit

  • Chores
    • Removed many sample databases, example datasets, and configuration templates used for development/testing.
    • Cleared several ignore rules so certain data and config file types may now be tracked.
    • Removed supporting README/docs from the data directory.
  • Tests
    • Updated CLI tests to use the relocated tutorial SQL fixture for migration-related test cases.

@ParticularlyPythonicBS ParticularlyPythonicBS added the Maintenance Code quality fixes and deprecation management label Mar 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 197c077f-c798-4950-9f4e-8813caa8f0be

📥 Commits

Reviewing files that changed from the base of the PR and between ade24d5 and 7637310.

📒 Files selected for processing (1)
  • tests/test_cli.py

Walkthrough

Removed the repository's sample data/configuration artifacts under data_files/ (example SQL schemas, migration scripts, TOML configs, READMEs, and .gitignore entries) and updated tests to use a centralized tutorial SQL fixture (temoa/tutorial_assets/utopia.sql).

Changes

Cohort / File(s) Summary
Top-level docs & ignores
data_files/.gitignore, data_files/README.txt, data_files/example_dbs/.gitignore, data_files/example_dbs/README.txt, data_files/my_configs/.gitignore
Deleted README and .gitignore files that documented/ignored sample DB and config artifacts.
Example DB SQL files
data_files/example_dbs/materials.sql, data_files/example_dbs/morris_utopia.sql, data_files/example_dbs/seasonal_storage.sql, data_files/example_dbs/stepped_demand.sql, data_files/example_dbs/survival_curve.sql, data_files/example_dbs/test_system.sql, data_files/example_dbs/utopia.sql
Removed seven full example SQL scripts (DDL, seed data, constraints, and indexes).
Sample configs (TOML)
data_files/my_configs/config_sample.toml, data_files/my_configs/materials.toml, data_files/my_configs/mga_utopia.toml, data_files/my_configs/monte_carlo_utopia.toml, data_files/my_configs/morris_utopia.toml, data_files/my_configs/seasonal_storage.toml, data_files/my_configs/stepped_demand.toml
Deleted multiple TOML scenario/config samples used for runs and mode-specific settings.
Legacy schema migrations
data_files/temoa_basics_0.sql, data_files/temoa_basics_1.sql, data_files/temoa_basics_2.sql, data_files/temoa_schema_v3.sql, data_files/temoa_schema_v3_1.sql, data_files/temoa_schema_v4.sql
Removed historical schema/migration SQL files that defined many core tables, indexes, initial lookups and seed rows.
Test update
tests/test_cli.py
Updated migrate-related tests to use temoa/tutorial_assets/utopia.sql (new UTOPIA_SQL_FIXTURE) instead of data_files/temoa_basics_0.sql across multiple test cases.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

database-schema

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'removing data_files' directly describes the main action across the changeset: bulk deletion of legacy data_files directory contents.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove_data_files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/test_cli.py`:
- Around line 160-161: Introduce a single shared constant (e.g.,
TUTORIAL_UTOPIA_SQL or UTOPIA_SQL_FIXTURE) that holds the Path(...) to the
utopia.sql fixture and replace the repeated inline assignments to input_file_src
in tests with that constant; update references in the test functions that
currently set input_file_src so they import or reference this new constant
(ensure the constant is defined at module scope near the top of
tests/test_cli.py and used in places that previously duplicated the Path).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6a83dc38-af63-4f91-bd5b-13d07def6d98

📥 Commits

Reviewing files that changed from the base of the PR and between a620716 and ade24d5.

📒 Files selected for processing (1)
  • tests/test_cli.py

Comment thread tests/test_cli.py Outdated
@ParticularlyPythonicBS ParticularlyPythonicBS merged commit cb703e5 into unstable Mar 24, 2026
12 checks passed
@ParticularlyPythonicBS ParticularlyPythonicBS deleted the remove_data_files branch March 24, 2026 22:19
@coderabbitai coderabbitai Bot mentioned this pull request Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Code quality fixes and deprecation management refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant