fix(recall): skip recall-dependent built-in skills when recall is disabled - #135
Merged
Conversation
…abled When `teamai recall disable` is run, the built-in skills (team-wiki-codebase, teamai-share-learnings) that depend on recall should not be deployed — matching existing behavior for recall rules and agents. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ission Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When `hooks inject` or `hooks remove` is called explicitly, skip the tool-root existence check so hooks are injected even if the tool directory doesn't exist yet (reconcileHooks already creates it via ensureDir). This fixes the E2E test failures on clean environments. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
teamai recall disableis run, the built-in skills (team-wiki-codebase,teamai-share-learnings) that depend on recall are now also skipped/removed — matching existing behavior for recall rules and agents.teamai recall enablere-deploys them.teamai pullrespects therecallEnabledconfig for skill deployment.Changes
src/builtin-skills.ts: AddedRECALL_DEPENDENT_SKILLSset andskipRecalloption todeployBuiltinSkills()src/pull.ts: PassskipRecalltodeployBuiltinSkills()in both call sitessrc/recall-toggle.ts: Remove recall skills on disable, re-deploy on enableTest plan
teamai recall disable→ verifyteam-wiki-codebaseandteamai-share-learningsare removed from~/.claude/skills/teamai pullwith recall disabled → verify those skills are NOT deployedteamai recall enable→ verify those skills are re-deployednpx tsc --noEmitpasses (no new type errors)npx vitest runpasses (no new test failures)🤖 Generated with Claude Code