Skip to content

fix(update): handle prerelease versions in compareVersions - #147

Merged
jeff-r2026 merged 1 commit into
Tencent:mainfrom
jeff-r2026:fix/compare-versions-prerelease
Jul 3, 2026
Merged

fix(update): handle prerelease versions in compareVersions#147
jeff-r2026 merged 1 commit into
Tencent:mainfrom
jeff-r2026:fix/compare-versions-prerelease

Conversation

@jeff-r2026

Copy link
Copy Markdown
Collaborator

Summary

  • Fix compareVersions to correctly handle prerelease suffixes (e.g. 1.2.3-beta.1)
  • Previously, prerelease versions would produce NaN during numeric comparison, causing beta users to never see update prompts for stable releases
  • Now splits off the -<prerelease> suffix before comparing, and treats prerelease as lower than the same core version (semver §11)

Test plan

  • New unit tests: prerelease < same release, prerelease < higher release, prerelease > lower release
  • Existing tests all pass (975 passed)
  • Type check passes
  • Build succeeds

🤖 Generated with Claude Code

Split off the prerelease suffix before numeric comparison so that
beta/alpha/rc users correctly see stable releases as newer (semver §11).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeff-r2026
jeff-r2026 force-pushed the fix/compare-versions-prerelease branch from 6b9bd0a to 846c51b Compare July 3, 2026 07:39
@jeff-r2026
jeff-r2026 merged commit 23a72a2 into Tencent:main Jul 3, 2026
7 checks passed
@jeff-r2026
jeff-r2026 deleted the fix/compare-versions-prerelease branch July 3, 2026 07:55
@hsuchifeng hsuchifeng mentioned this pull request Jul 3, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant