fix: recursively deploy built-in skill directories - #92
Merged
jeff-r2026 merged 1 commit intoJul 1, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #88.
deployBuiltinSkillspreviously copied only top-level files from each built-in skill directory. This causedteam-wiki-codebaseto be deployed without its nestedreferences/andscripts/directories, leaving the skill incomplete afterteamai pull.This PR changes built-in skill deployment to recursively copy the full skill directory while skipping
.-prefixed files/directories as suggested in #88.It also updates ESM path resolution to use
fileURLToPath(import.meta.url), which keeps the built-in skills path valid on Windows and remains correct on Linux/macOS.Changes
.-prefixed files/directories during recursive copy.team-wiki-codebasedeploys nestedreferences/andscripts/files.fileURLToPath(import.meta.url)for cross-platform built-in skills path resolution.Testing
npx vitest run src/__tests__/skip-uninstalled-tools.test.tsnpx tsc --noEmitnpm run buildgit diff --check