Skip to content

fix(recall): resolve remaining bugs from #82, #84, #94 - #98

Merged
jeff-r2026 merged 2 commits into
Tencent:mainfrom
m0Nst3r873:worktree-fix-issues-82-84-94
Jul 2, 2026
Merged

fix(recall): resolve remaining bugs from #82, #84, #94#98
jeff-r2026 merged 2 commits into
Tencent:mainfrom
m0Nst3r873:worktree-fix-issues-82-84-94

Conversation

@m0Nst3r873

Copy link
Copy Markdown
Collaborator

Summary

Fixes the remaining bugs reported in issues #82, #84, and #94 that were not fully resolved by PR #91.

Issue #82 — knowledge-reconciler

  • Bug1: buildConfidence → cumulative sum Math.min(1, sum), corroborating evidence now increases confidence
  • Bug2: Stale detection → Math.abs(fromMs - toMs) measures drift between two sides

Issue #84 — codebase graph retrieval

  • Bug1: loadWikiPages recursive traversal (modules/*.md now indexed)
  • Bug2: Removed broken rawTokenCount; uses tokenizer.ts with correct camelCase/PascalCase split
  • Bug3: extractCodebase load-merge-save prevents overwriting other repos
  • Bug4: Unified tokenizer — single tokenizer.ts for both paths
  • Bug5: loadGraphIndex schema validation + null fallback

Issue #94 — PR #91 follow-ups

Test plan

  • npx tsc --noEmit — clean
  • npx vitest run — 131 files, 1691 tests pass
  • 15 new regression tests

Closes #82, closes #84, closes #94

🤖 Generated with Claude Code

@m0Nst3r873
m0Nst3r873 force-pushed the worktree-fix-issues-82-84-94 branch 3 times, most recently from 3297fc8 to aa06e09 Compare July 1, 2026 09:38
Tencent#94

- buildConfidence: cumulative sum capped at 1.0 (Tencent#82 bug1, Tencent#94 issue3)
- stale detection: Math.abs(fromMs - toMs) for drift (Tencent#82 bug2)
- loadWikiPages: recursive traversal (Tencent#84 bug1)
- tokenizer.ts: preserve camelCase/PascalCase split, fix OOM (Tencent#84 bug2)
- extractCodebase: load-merge-save graph (Tencent#84 bug3)
- unified tokenizer: both paths use tokenizer.ts (Tencent#84 bug4)
- loadGraphIndex: schema guard (Tencent#84 bug5)
- BM25 dl/tf: countOccurrences truncates to MAX_TOKENIZE_CHARS (Tencent#94 issue1)
- shrink-guard: restore 20% soft threshold (Tencent#94 issue2)
- tokenizer.ts: MAX_TOKENIZE_CHARS 50k + iterative segmenter (Tencent#94 issue4)
- i18n: CLI output strings in English (review/import/drift/extract)
- 15 regression tests

Closes Tencent#82, closes Tencent#84, closes Tencent#94
@m0Nst3r873
m0Nst3r873 force-pushed the worktree-fix-issues-82-84-94 branch from aa06e09 to 57deb52 Compare July 1, 2026 09:42
Replace autoPushTeamRepo (direct push to main) with autoPushViaMR
(create branch + create MR/PR) for import flows:

- Add autoPushViaMR() in src/utils/git.ts: creates branch, commits,
  pushes, creates MR via provider, returns to default branch
- Replace direct push in import-repo.ts main flow and deep-enrich
  background callback
- Replace direct push in import-repo-list.ts batch flow
- Reuses existing pushRepoBranch + createPrWithFallback infrastructure

AI-generated knowledge content now requires review before merging
into the team knowledge repository.
@jeff-r2026
jeff-r2026 merged commit 402853b into Tencent:main Jul 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants