feat: add ComplyWith to string-specialized Elements#952
Merged
vbreuss merged 2 commits intoMay 16, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the missing ComplyWith(Action<IThatSubject<string?>>) overload to the string-specialized Elements types for both IEnumerable<string?> and IAsyncEnumerable<string?>, enabling quantifier chains like That(strings).All().ComplyWith(...) to compile and behave like the generic Elements<TItem> variants.
Changes:
- Add
ComplyWith(...)toThatEnumerable.Elements(string specialization) andThatAsyncEnumerable.Elements(string specialization). - Add/extend tests to cover
ComplyWithonIEnumerable<string?>andIAsyncEnumerable<string?>quantifier chains. - Update API approval baselines (
aweXpect_netstandard2.0,aweXpect_net8.0,aweXpect_net10.0) to include the new public methods.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/aweXpect.Tests/Collections/ThatEnumerable.All.ComplyWith.StringTests.cs | New tests covering ComplyWith for IEnumerable<string?> quantifiers. |
| Tests/aweXpect.Tests/Collections/ThatAsyncEnumerable.All.ComplyWith.Tests.cs | Adds string-specific tests for async ComplyWith and minor formatting cleanup. |
| Tests/aweXpect.Api.Tests/Expected/aweXpect_netstandard2.0.txt | Updates API baseline to include ThatEnumerable.Elements.ComplyWith(...) for IEnumerable<string?>. |
| Tests/aweXpect.Api.Tests/Expected/aweXpect_net8.0.txt | Updates API baseline for both sync and async string-specialized Elements.ComplyWith(...). |
| Tests/aweXpect.Api.Tests/Expected/aweXpect_net10.0.txt | Updates API baseline for both sync and async string-specialized Elements.ComplyWith(...). |
| Source/aweXpect/That/Collections/ThatEnumerable.Elements.ComplyWith.cs | Adds the string-specialized Elements.ComplyWith(...) implementation (sync). |
| Source/aweXpect/That/Collections/ThatAsyncEnumerable.Elements.ComplyWith.cs | Adds the string-specialized Elements.ComplyWith(...) overload (async). |
Contributor
Test Results 23 files - 27 23 suites - 27 7m 47s ⏱️ -24s Results for commit 9ad9a34. ± Comparison against base commit 0d5b1a9. This pull request removes 3179 and adds 3172 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Contributor
🚀 Benchmark ResultsDetails
|
Contributor
👽 Mutation ResultsaweXpectDetails
The final mutation score is 76.30%Coverage Thresholds: high:80 low:60 break:0aweXpect.CoreDetails
The final mutation score is NaN%Coverage Thresholds: high:80 low:60 break:0 |
The Elements class for IEnumerable<string?> and IAsyncEnumerable<string?> was missing the ComplyWith overload that its generic siblings expose. This made `That(stringCollection).All().ComplyWith(it => ...)` and related quantifier chains fail to compile. Add the parallel overload on both sync and async sides.
vbreuss
force-pushed
the
topic/add-ComplyWith-to-string-specialized-Elements
branch
from
54349fc to
a6d92a3
Compare
vbreuss
force-pushed
the
topic/add-ComplyWith-to-string-specialized-Elements
branch
from
a6d92a3 to
9ad9a34
Compare
|
github-actions Bot
added a commit
that referenced
this pull request
May 16, 2026
…lized Elements (#952) by Valentin Breuß
github-actions Bot
added a commit
that referenced
this pull request
May 16, 2026
…lized Elements (#952) by Valentin Breuß
Contributor
|
This is addressed in release v2.34.0. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Elements class for IEnumerable<string?> and IAsyncEnumerable<string?> was missing the ComplyWith overload that its generic siblings expose. This made
That(stringCollection).All().ComplyWith(it => ...)and related quantifier chains fail to compile.Add the parallel overload on both sync and async sides.