Development#7
Open
GovtGeek wants to merge 22 commits into
Open
Conversation
Remove non-existent spell IDs and localized names (handles compatibility between retail and classic)
…ondary skill in TBC)
… or item IDs Added special case handling for enchanting (Tradeskill vs Crafting)
…sAdvancedProfessionInfo is set
Reworked saving reagents and result items to (hopefully) work with Mists, TBC, and Classic Era Wipe categories in enchanting (bad interaction with tradeskill window values)
Fix for OnChatMsgSystem
… and _IterateRecipes
…e the way to scan professions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added all professions, then removed dynamically based on expansion
Added ScanProfessionLinks_NonRetail to Retail version
Fixed Broadcast to use AddonFactory
Modified _IterateRecipes to handle possible incorrect calling (3 versus 4 variables)