Chunk ScanAllFactions main loop + toc 120005#13
Open
mcc1 wants to merge 2 commits into
Open
Conversation
12.0 introduces a much larger faction list (400+ when SaveHeaders expands every category), and ScanSingleFaction makes 4-5 C_Reputation / C_GossipInfo API calls per faction. The synchronous loop blows the "script ran too long" budget on PLAYER_ALIVE. Process 60 factions per frame, then yield via C_Timer.After(0, ...). RestoreHeaders runs once the chunked walk finishes - it cannot be reordered because it needs the header counter that SaveHeaders set up. A generation counter lets a fresh ScanAllFactions cleanly supersede any in-flight chunked pass instead of running concurrently with it. The existing 3s debounce in OnUpdateFaction is preserved. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
Test plan
script ran too longfrom DataStore_Reputations./dump DataStore:GetReputationInfo("char", factionID)returns expected data across all categories (including Khaz Algar / Midnight factions previously dropped mid-scan).🤖 Generated with Claude Code