Skip to content

Tclint 2#3279

Merged
maliberty merged 6 commits into
The-OpenROAD-Project:masterfrom
luarss:topic/lint-tcl-2
Jul 1, 2025
Merged

Tclint 2#3279
maliberty merged 6 commits into
The-OpenROAD-Project:masterfrom
luarss:topic/lint-tcl-2

Conversation

@luarss
Copy link
Copy Markdown
Contributor

@luarss luarss commented Jun 30, 2025

  • Targets tclint for flow/util scripts

luarss added 6 commits June 30, 2025 18:04
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
Signed-off-by: Jack Luar <jluar@precisioninno.com>
- to avoid messing with regex spacing

Signed-off-by: Jack Luar <jluar@precisioninno.com>
@luarss luarss requested a review from maliberty July 1, 2025 01:06
@maliberty
Copy link
Copy Markdown
Member

Why use tclint-disable-next-line line-length instead of just breaking the line(s)?

@luarss
Copy link
Copy Markdown
Contributor Author

luarss commented Jul 1, 2025

Cases I encountered for this were:

  • Line length violations are comments -> no harm splitting, or we can preserve original
  • file_name cannot be neatly divided into lines without introducing newlines

@maliberty
Copy link
Copy Markdown
Member

Cell veneer will hopefully go away one day so I won't worry about it too much.

@maliberty maliberty merged commit 124805b into The-OpenROAD-Project:master Jul 1, 2025
8 checks passed
@luarss luarss deleted the topic/lint-tcl-2 branch July 2, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants