synth: more consistent naming#3295
Closed
oharboe wants to merge 1 commit into
Closed
Conversation
I'm not keen on changing 1_1_yosys stem as I don't know what tools that rely on that name, like metrics, but canonicalization happens before 1_1_yosys, so the compromise is to create 1_0_yosys_canonicalize stem. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Member
|
1_0 is inconsistent with how we name substeps in all other steps in the flow. I find that more objectionable than have 1_1 become 1_2. We have added/removed steps in the flow before so its possible. |
Collaborator
Author
I'll look at that tomorrow. I want to have this in the can before I create a followup to #3294 to do hashes for synthesis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not keen on changing 1_1_yosys stem as I don't know what tools that rely on that name, like metrics, but canonicalization happens before 1_1_yosys, so the compromise is to create 1_0_yosys_canonicalize stem.