Improve macOS handling in setup and dependency installer scripts#4023
Merged
maliberty merged 2 commits intoMar 22, 2026
Merged
Conversation
Signed-off-by: Sahil Jaiswal <jaiswalsahil7741@gmail.com>
luarss
reviewed
Mar 21, 2026
| IS_DARWIN=true | ||
| fi | ||
|
|
||
| if $IS_DARWIN && [[ $EUID -eq 0 ]]; then |
Contributor
Author
There was a problem hiding this comment.
Actually setup.sh invokes DependencyInstaller.sh and dependencies are installed via Homebrew which do not need sudo. Additionally DependencyInstaller.sh is build in such a way that on mac its recommend to not use sudo. If we run it using sudo then script fails and exits giving below error.
Look Line 410 of DependencyInstaller.sh
| echo "This script must be run with sudo" | ||
| # macOS detection | ||
| IS_DARWIN=false | ||
| if [[ "$(uname)" == "Darwin" ]]; then |
Contributor
There was a problem hiding this comment.
maybe we can follow existing coding style, it should be okay to repeat if [[ "$OSTYPE" == "darwin"* ]]; then multiple times
Contributor
Author
There was a problem hiding this comment.
Thanks, I did the changes please check
Signed-off-by: Sahil Jaiswal <jaiswalsahil7741@gmail.com>
maliberty
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves macOS behavior in the ORFS setup path:
sudoon Linux and disallow on macOSsysctlfor CPU count on macOS instead ofnprocAddresses #4022