Stabilize RCX generate_pattern regression log#10365
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the generate_pattern.tcl test script to suppress specific RCX debug messages during the bench_wires command, aiming to prevent platform-dependent log variations. Feedback suggests that the messages should remain suppressed for the duration of the script to ensure stability for all subsequent RCX-related commands.
| unsuppress_message RCX 437 | ||
| unsuppress_message RCX 438 |
There was a problem hiding this comment.
The messages are unsuppressed before the bench_verilog command is executed. If bench_verilog (which is also an RCX command) triggers these platform-dependent debug messages, the log comparison will remain unstable. It is safer to keep these messages suppressed until the end of the script or at least until all RCX-related commands are finished. Alternatively, since this is a standalone test script, you could omit the unsuppress_message calls entirely as the process terminates shortly after.
There was a problem hiding this comment.
Done in 2ad8ffc: the suppression now remains in effect for the rest of this standalone regression, including bench_verilog.
Signed-off-by: naveenvenk17 <naveenvenkat1711@gmail.com>
a3964be to
2ad8ffc
Compare
|
I am confused, all that is in the .ok is there is no mention of these messages. |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
The checked-in .ok is the desired clean log. RCX-0437/RCX-0438 are optional debug shape messages that showed up in the failing environment but should not be part of the stable golden log, so the suppression is there to keep them out on builds/platforms that emit them. The suppression now stays active through the rest of this standalone script, including bench_verilog. |
|
debug messages don't print in this test so why do they need to be suppressed? What is the "failing environment"? |
Summary
rcx.generate_pattern.tcllog comparison by suppressing optional RCX debug shape messages in this standalone regression.RCX-0437/RCX-0438suppressed for the remainder of the short script so subsequent RCX-related commands cannot reintroduce platform-dependent log lines.Closes #842.
Tests
git diff --check -- src/rcx/test/generate_pattern.tclopenroad -no_splash -no_init -exit /tmp/rcx_suppress_check.tcl(verifiedRCX-0437/RCX-0438are suppressed)/usr/bin/openroad -no_splash -no_init -exit generate_pattern.tclfrom a temporary WSL worktree (script runs and emits noRCX-0437/RCX-0438; local packaged OpenROADv2.0-17598-ga008522d8generates artifact differences versus current goldens, so this is not a valid full golden comparison)bazel test //src/rcx/test:generate_pattern-tcl_test --test_timeout=1200 --noshow_progress; blocked in this WSL image by a remote-cached OpenROAD binary requiringGLIBC_2.38.string.hwhile compilingzstd.