rsz: Rename SizeDownMove to ReduceLoadMove#10433
Open
erendn wants to merge 3 commits into
Open
Conversation
Signed-off-by: Eren Dogan <erendogan@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the "SizeDown" optimization move to "ReduceLoad" throughout the rsz package. The changes encompass file renames, documentation updates, modifications to core C++ logic, and adjustments to the Tcl/Python interfaces and test suite. The review feedback identifies several internal log and debug messages that still use the old terminology and provides code suggestions to update them for consistency with the new naming convention.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eren Dogan <erendogan@google.com>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames SizeDownMove to avoid confusion. There should still also be a SizeDownMove implementation but it should only down size the driver gate, not its fanout.
Type of Change
Impact
The PR shouldn't change any behavior.
Verification
./etc/Build.sh).