IWYU: Fix some missing includes#10438
Draft
hzeller wants to merge 1 commit into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates header includes across various modules, including dbSta, gui, odb, psm, rcx, rsz, and utl, to ensure all necessary dependencies are explicitly declared. It also includes minor formatting refactors in dbCompare.inc for deleted operator declarations. I have no feedback to provide as there were no review comments.
hzeller
force-pushed
the
feature-20260515-fix-inc
branch
from
5a003e4 to
83baa9e
Compare
Breakdown: ``` src/dbSta/src/dbEditHierarchy.cc: #include "odb/dbTypes.h" for odb::dbIoType src/gui/src/scriptWidget.cpp: #include "spdlog/common.h" for spdlog::level::level_enum src/gui/src/scriptWidget.h: #include "spdlog/sinks/sink.h" for spdlog::sinks::sink src/odb/src/3dblox/3dblox.cpp: #include <map> for std::map src/odb/src/3dblox/3dblox.cpp: #include <memory> for std::unique_ptr src/odb/src/3dblox/3dblox.cpp: #include <vector> for std::vector src/odb/src/db/dbModNet.cpp: #include <functional> for std::function src/odb/src/db/dbModNet.cpp: #include <string> for std::string src/psm/src/debug_gui.h: #include <any> for std::any src/psm/src/debug_gui.h: #include <functional> for std::function src/rcx/src/ext.cpp: #include "rcx/ext_options.h" for PatternOptions src/rcx/src/extPatterns.cpp: #include "rcx/ext_options.h" for PatternOptions src/rsz/src/Graphics.hh: #include "rsz/Resizer.hh" for rsz::BufferedNetPtr src/rsz/src/move/MoveCandidate.cc: #include "OptimizerTypes.hh" for rsz::Target src/rsz/src/move/RerouteCandidate.cc: #include "OptimizerTypes.hh" for rsz::Target src/rsz/src/policy/SetupDirectionalPolicy.hh: #include "MoveCommitter.hh" for rsz::MoveCommitter src/rsz/src/policy/SetupDirectionalPolicy.hh: #include "OptimizerTypes.hh" for rsz::OptimizerRunConfig src/rsz/src/policy/SetupLegacyMtPolicy.cc: #include "policy/SetupLegacyPolicy.hh" for rsz::SetupLegacyPolicy src/rsz/src/policy/SetupWnsPolicy.hh: #include "MoveCommitter.hh" for rsz::MoveCommitter src/rsz/src/policy/SetupWnsPolicy.hh: #include "OptimizerTypes.hh" for rsz::OptimizerRunConfig src/utl/include/utl/Logger.h: #include "spdlog/common.h" for spdlog::level::level_enum src/utl/include/utl/Logger.h: #include "spdlog/logger.h" for spdlog::logger src/utl/src/Logger.cpp: #include "spdlog/logger.h" for spdlog::logger src/web/src/request_handler.cpp: #include <map> for std::map src/tst/src/fixture.cpp: #include "tools/cpp/runfiles/runfiles.h" for bazel::tools::cpp::runfiles::Runfiles src/odb/src/def/def/defrData.cpp: #include "defrReader.hpp" for DEF_MSGS src/odb/src/def/def/defrSettings.cpp: #include "defrReader.hpp" for DEF_MSGS ``` Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260515-fix-inc
branch
from
83baa9e to
e69cd93
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include "sta/MinMax.hh" | ||
| #include "sta/Sta.hh" | ||
| #include "tcl.h" // IWYU pragma: keep (clang-tidy, you're drunk) | ||
| #include "tools/cpp/runfiles/runfiles.h" |
Contributor
There was a problem hiding this comment.
warning: 'tools/cpp/runfiles/runfiles.h' file not found [clang-diagnostic-error]
#include "tools/cpp/runfiles/runfiles.h"
^
| @@ -32,6 +32,7 @@ | |||
|
|
|||
| #include "def_parser.hpp" | |||
Contributor
There was a problem hiding this comment.
warning: 'def_parser.hpp' file not found [clang-diagnostic-error]
#include "def_parser.hpp"
^
Collaborator
Author
|
(will need to fix the suggestions first) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breakdown:
Summary
[Describe your changes here]
Type of Change
Impact
[How does this change the tool's behavior?]
Verification
./etc/Build.sh).Related Issues
[Link issues here]