Fix includes in dpl/src/infrastructure#10440
Open
hzeller wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates include paths across several files in the dpl infrastructure directory to use the explicit "infrastructure/" prefix and adds the "src" directory to the include paths in the mpl BUILD file. It also documents a cyclic dependency in the dpl BUILD file. I have no feedback to provide.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
hzeller
force-pushed
the
feature-20260515-cleaner-inc
branch
from
773595e to
b0a8b1f
Compare
... they should be prefixed by infrastructure/ as the `-I`-paths only provide the src/ prefix. Also, document a cyclic dependency. Signed-off-by: Henner Zeller <h.zeller@acm.org>
hzeller
force-pushed
the
feature-20260515-cleaner-inc
branch
from
b0a8b1f to
d1ad949
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... they should be prefixed by infrastructure/ as the
-I-paths only provide the src/ prefix.Also, document a cyclic dependency.