Clean-up old header behind ifdef, not needed anymore.#10446
Merged
maliberty merged 1 commit intoMay 16, 2026
Conversation
That also made it possible to associate all headers with providing libraries and notice a non-needed dependency. Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the //src/sta:opensta_lib dependency from the utl library's BUILD file and refactors the include statements in Logger.cpp. Specifically, it simplifies the spdlog header inclusions by removing version-specific conditional logic and the spdlog.h header, while also reordering other internal headers. I have no feedback to provide as there were no review comments.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
maliberty
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That also made it possible to associate all headers with providing libraries and notice a non-needed dependency.